02456: wrong sector size at CD_TRACK_MODE2 conversion routine

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
02456	Core	Typo	Always	Sep 29, 2008, 15:30	Oct 30, 2008, 03:09

Tester	ajax16384	View Status	Public	Platform
Assigned To	R. Belmont	Resolution	Fixed	OS
Status [?]	Resolved			Driver
Version	0.128u1	Fixed in Version	0.128u2	Build
		Fixed in Git Commit		Github Pull Request #

Summary	02456: wrong sector size at CD_TRACK_MODE2 conversion routine
Description	src/lib/util/cdrom.c: "cdrom_read_data" function contains following lines: /* return mode 2 2336 byte data from a RAW sector / if ((datatype == CD_TRACK_MODE2) && ((tracktype == CD_TRACK_MODE1_RAW) \|\| (tracktype == CD_TRACK_MODE2_RAW))) { memcpy(buffer, &file->cache[(sectoroffs CD_FRAME_SIZE) + 16], 2048); return 1; } 2048 should be replaced with 2336 value
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems

Attached Files

No.02666 Haze Senior Tester Oct 2, 2008, 19:34	it would be nice to have some feedback on this, RB, you wrote the code, it's somewhat critical if it's wrong (although I still think the entire CHD-CD stuff is entirely inadequate for modern systems, or any discs that bend the rules)