03413: 64-bit compiler warnigs

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
03413	Compiling	Minor	Always	Aug 30, 2009, 09:52	Aug 31, 2009, 05:48

Tester	Scagazza	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	aaron	Resolution	Fixed	OS	Windows XP (64-bit)
Status [?]	Resolved			Driver
Version	0.133u4	Fixed in Version	0.133u5	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	03413: 64-bit compiler warnigs
Description	src\mame\drivers\tmaster.c(544) : warning C4114: same type qualifier used more than once src\emu\cpu\superfx\superfx.c(549) : warning C4098: 'superfx_mmio_write' : 'void' function returning a value
Steps To Reproduce
Additional Information
Github Commit

Flags	64-bit specific
Regression Version
Affected Sets / Systems

Attached Files

No.04880 Tafoid Administrator Aug 30, 2009, 13:43 edited on: Aug 30, 2009, 13:49	Modified: trunk/src/emu/cpu/superfx/superfx.c =================================================================== --- trunk/src/emu/cpu/superfx/superfx.c 2009-08-30 01:59:58 UTC (rev 6641) +++ trunk/src/emu/cpu/superfx/superfx.c 2009-08-30 02:04:21 UTC (rev 6642) @@ -546,7 +546,7 @@ if(addr >= 0x3100 && addr <= 0x32ff) { - return superfx_cache_mmio_write(cpustate, addr - 0x3100, data); + superfx_cache_mmio_write(cpustate, addr - 0x3100, data); + return; } if(addr >= 0x3000 && addr <= 0x301f) Modified: trunk/src/mame/drivers/tmaster.c =================================================================== --- trunk/src/mame/drivers/tmaster.c 2009-08-30 01:59:58 UTC (rev 6641) +++ trunk/src/mame/drivers/tmaster.c 2009-08-30 02:04:21 UTC (rev 6642) @@ -541,7 +541,7 @@ #define GALGAMES_EEPROM_CART3 "eeprom_cart3" #define GALGAMES_EEPROM_CART4 "eeprom_cart4" -const char const galgames_eeprom_names[5] = { GALGAMES_EEPROM_BIOS, GALGAMES_EEPROM_CART1, GALGAMES_EEPROM_CART2, GALGAMES_EEPROM_CART3, GALGAMES_EEPROM_CART4 }; +const char galgames_eeprom_names[5] = { GALGAMES_EEPROM_BIOS, GALGAMES_EEPROM_CART1, GALGAMES_EEPROM_CART2, GALGAMES_EEPROM_CART3, GALGAMES_EEPROM_CART4 }; static READ16_HANDLER( galgames_eeprom_r ) {
No.04883 Firewave Senior Tester Aug 31, 2009, 05:48	Shouldn't the second one be fixed as "const char * const"?

No.04880

Tafoid

Administrator

Aug 30, 2009, 13:43

edited on: Aug 30, 2009, 13:49

Modified: trunk/src/emu/cpu/superfx/superfx.c
===================================================================
--- trunk/src/emu/cpu/superfx/superfx.c    2009-08-30 01:59:58 UTC (rev 6641)
+++ trunk/src/emu/cpu/superfx/superfx.c    2009-08-30 02:04:21 UTC (rev 6642)
@@ -546,7 +546,7 @@

    if(addr >= 0x3100 && addr <= 0x32ff)
    {
-        return superfx_cache_mmio_write(cpustate, addr - 0x3100, data);
+        superfx_cache_mmio_write(cpustate, addr - 0x3100, data);
+        return;
   }

    if(addr >= 0x3000 && addr <= 0x301f)

Modified: trunk/src/mame/drivers/tmaster.c
===================================================================
--- trunk/src/mame/drivers/tmaster.c    2009-08-30 01:59:58 UTC (rev 6641)
+++ trunk/src/mame/drivers/tmaster.c    2009-08-30 02:04:21 UTC (rev 6642)
@@ -541,7 +541,7 @@
#define GALGAMES_EEPROM_CART3 "eeprom_cart3"
#define GALGAMES_EEPROM_CART4 "eeprom_cart4"

-const char const *galgames_eeprom_names[5] = { GALGAMES_EEPROM_BIOS, GALGAMES_EEPROM_CART1, GALGAMES_EEPROM_CART2, GALGAMES_EEPROM_CART3, GALGAMES_EEPROM_CART4 };
+const char *galgames_eeprom_names[5] = { GALGAMES_EEPROM_BIOS, GALGAMES_EEPROM_CART1, GALGAMES_EEPROM_CART2, GALGAMES_EEPROM_CART3, GALGAMES_EEPROM_CART4 };

static READ16_HANDLER( galgames_eeprom_r )
{

No.04883

Firewave

Senior Tester

Aug 31, 2009, 05:48

Shouldn't the second one be fixed as "const char * const"?