04854: All sets in turbo.c: Slowdown

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
04854	Speed	Minor	Always	May 22, 2012, 13:03	May 26, 2012, 18:21

Tester	M.A.S.H.	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	hap	Resolution	Fixed	OS	Windows XP
Status [?]	Resolved			Driver	sega/turbo.cpp
Version	0.146	Fixed in Version	0.146u1	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	04854: All sets in turbo.c: Slowdown
Description	There is a massiv slowdown in Turbo, Buck Rogers and Subroc-3D since MAME 0.144u7. Turbo for example from 236% to 98% and since MAME 0.145u7 from 98% to 82%.
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version	0.144u7
Affected Sets / Systems	All sets in turbo.c

Attached Files

No.08629 hap Developer May 22, 2012, 16:00	turbo 0.144u7 slowdown: r15135: ok r15156: slow possibly regressed at r15143: Move devices into a proper hierarchy and handle naming and paths consistently for devices, I/O ports, memory regions, memory banks, and memory shares. [Aaron Giles]
No.08661 hap Developer May 25, 2012, 15:54	ok, r15143 indeed, and cause confirmed to be due to updated region tag lookup method being a lot slower: before: const UINT8 sprite_gfxdata = machine.region("gfx1")->base(); after: const UINT8 sprite_gfxdata = machine.root_device().memregion("gfx1")->base();
No.08662 M.A.S.H. Senior Tester May 26, 2012, 10:09 edited on: May 26, 2012, 10:09	Thanks hap for the turbo driver optimation. Turbo is now faster than in 0.144u6 (266%). It was a very heavy optimation. Question: Will every driver now be optimized? Or can a program do this?
No.08663 hap Developer May 26, 2012, 18:21	Globally converting gfx tags to pointers can be done automatically. Will someone do it? I don't know. =p