Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
04872 Graphics Minor Always May 26, 2012, 16:08 Aug 15, 2017, 20:09
Tester M.A.S.H. View Status Public Platform MAME (Self-compiled)
Assigned To Kale Resolution Fixed OS Windows XP
Status [?] Resolved Driver labyrunr.cpp
Version 0.146 Fixed in Version 0.189 Build Normal
Summary 04872: tricktrp: Graphic priority issue
Description Since 0.99u3 the flags are behind the "Trick Trap" text and the shield in the middle is missing the knight with his wife
Comparing the soucre from 0.99u2 and 0.99u3 i found typos in src\mame\video\labyrunr.c.

To get the flags back changed line 278 from
state->m_layer0->draw(bitmap, finalclip0, 0, 1);
to
state->m_layer0->draw(bitmap, finalclip0, 0, 0);

and line 282 from
state->m_layer1->draw(bitmap, finalclip1, 0, 1);
to
state->m_layer1->draw(bitmap, finalclip1, 0, 0);


Maybe this typo comes while Pierpaolo added the extra line: tate->m_layer0->draw(bitmap, finalclip3, 0, 1);
with the "1)" at the end.
Steps To Reproduce
Additional Information
Flags
Regression Version 0.99u3
Affected Sets / Systems tricktrp
Attached Files
gif file icon tricktrp-099u2.gif (7,337 bytes) May 26, 2012, 16:08 Uploaded by M.A.S.H.
M.A.S.H.
png file icon tricktrp-0146.png (5,606 bytes) May 26, 2012, 16:08 Uploaded by M.A.S.H.
M.A.S.H.
Relationships
There are no relationsihp linked to this issue.
Notes
7
User avatar
No.08664
hap
Developer
May 26, 2012, 19:54
Changes like these are often done on purpose, I wouldn't assume rightaway it's a typo/accident.
the fix something --> break something else at the same time, is a coder's nightmare :D
User avatar
No.08666
M.A.S.H.
Senior Tester
May 26, 2012, 23:45
OK. Better we asked Pierpaolo Prazzoli.
Set Assigned To Reip.
User avatar
No.08667
Tafoid
Administrator
May 26, 2012, 23:47
It is not good policy to assign something to someone unless they know about it first - Developers don't like be assigned things they do not know about, trust me. If he get contacted and wants to look at this, he has an account and can assign to himself as needed.

Thank you.
User avatar
No.08668
M.A.S.H.
Senior Tester
May 26, 2012, 23:51
What????
I don't understand. Reip = Pierpaolo Prazzoli and Pierpaolo made the changes in 0.99u3. So we Set Assigned To Reip.
User avatar
No.08670
hap
Developer
May 27, 2012, 00:13
edited on: May 27, 2012, 00:14
no, assign only to self
(unless the bug is resolved and the assignee is already known)

User avatar
No.08672
Haze
Senior Tester
May 27, 2012, 12:35
reip isn't an active dev, assigning it to him will only result in it *never* being fixed.
User avatar
No.14096
Kale
Developer
Aug 15, 2017, 20:09
Looks like MASH was right in a sense. The HW actually uses per-tile priority.