05583: GBA: Pokemon Sapphire crashes BIOS on fullpath, runs fine on softlist

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
05583	Crash/Freeze	Critical (emulation)	Always	May 13, 2014, 11:25	May 15, 2014, 05:16

Tester	BPzeBanshee	View Status	Public	Platform	MESS (Official Binary)
Assigned To	etabeta	Resolution	Fixed	OS	Windows Vista/7/8 (64-bit)
Status [?]	Resolved			Driver	nintendo/gba.cpp
Version	0.153	Fixed in Version	0.154	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	05583: GBA: Pokemon Sapphire crashes BIOS on fullpath, runs fine on softlist
Description	I attempted to run "Pokémon - Sapphire Version (Euro, USA, Rev. 2)" via fullpath using commandline. The BIOS behaves as if it accepts a valid game within the slot, then fades to white and does not continue any further. MESS itself runs fine but the emulation appears to have completely stalled. The console log from running commandline showed: GBA: Detected (ROM) FLASH_1M RTC GBA: Emulate FLASH_1M RTC GBA: Detected (ROM) FLASH_1M RTC GBA: Emulate FLASH_1M RTC Running the same file via soflist runs fine. The only entry that showed up on commandline was: GBA: Detected (XML) gba_flash_1m It seems prior to slotification of gba.c running via fullpath worked perfectly. I personally tested MESS 0.146u1 via fullpath, console output was as follows: GBA: Detected (ROM) FLASH_1M RTC GBA: Game Code "AXPE" GBA: Emulate FLASH_1M RTC When I brought the subject up on Bannister Forums LoganB did some searching and found the error was introduced between 0.148u5 and 0.149 (r23151 and r23624 in gba.c).
Steps To Reproduce	For crash, I simply run the file via fullpath - "mess.exe gba -cart 'roms/pokemon - sapphire version (usa, europe) (rev 2).bin'" and let it do its thing. To compare, it runs fine through soflist when I use "mess.exe gba -cart pokesaph".
Additional Information	Thread which I discussed the issue prior to submitting this bug located here: http://forums.bannister.org/ubbthreads.php?ubb=showflat&Number=94256 As detailed in the thread (which was about the real-time clock emulation) I originally used a different ROM from my personal dump and was able to play the game, but upon attempting to save the game crashed with a save fail message. Running that ROM via softlist gives me a warning about an incorrect dump but I was able to save and run the game fine. It was then I tried my personal dump and found that it wouldn't even start, which led to the suspicion of a bug on MESS' side rather than anything I've done.
Github Commit

Flags
Regression Version	0.149
Affected Sets / Systems	GBA

Attached Files

No.10708 etabeta Developer May 15, 2014, 05:16	a stupid mistake caused games with RTC not to have the NVRAM correctly recognized from fullpath. fixed in rev. 30450.