05684: All sets in coco12.c, coco3.c: It is impossible to Format a floppy disk CRASH

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
05684	Crash/Freeze	Critical (emulator)	Always	Aug 20, 2014, 19:18	Jul 3, 2015, 22:16

Tester	Robert Gault	View Status	Public	Platform	MESS (Official Binary)
Assigned To	Duke	Resolution	Fixed	OS	Windows XP
Status [?]	Resolved			Driver	trs/coco12.cpp
Version	0.154	Fixed in Version	0.163	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	05684: All sets in coco12.c, coco3.c: It is impossible to Format a floppy disk CRASH
Description	With any coco emulation that has a disk ROM, mount a floppy disk in any of the four slots and enter DSKINI#, where # is the number of the slot where the .dsk image was mounted. The command appears to proceed and then ----------------------------------------------------- Exception at EIP=015EFB89 (emu_timer::adjust(attotime, int, attotime const&)+0x0029): ACCESS VIOLATION While attempting to read memory at 08033EAD ----------------------------------------------------- EAX=00000000 EBX=052BFBCD ECX=00000000 EDX=00001D1A ESI=08030801 EDI=031BB360 EBP=0022B478 ESP=0022B420 ----------------------------------------------------- Stack crawl: 0022B478: 015EFB89 (emu_timer::adjust(attotime, int, attotime const&)+0x0029) 0022B4C8: 00D22272 (wd1770_device::wd17xx_timed_data_request()+0x00c2) 0022B4F8: 00D23E7C (wd1770_device::data_w(address_space&, unsigned int, unsigned char, unsigned char)+0x011c) 0022B548: 00B4265E (coco_fdc_device::write(address_space&, unsigned int, unsigned char, unsigned char)+0x005e) 0022B578: 00B4569C (cococart_slot_device::write(address_space&, unsigned int, unsigned char, unsigned char)+0x003c) 0022B5A8: 0093A4C5 (coco_state::ff40_write(address_space&, unsigned int, unsigned char, unsigned char)+0x0035) 0022B5E8: 01F08DC9 (address_space_specific<unsigned char, (endianness_t)1, false>::write_byte(unsigned int, unsigned c har)+0x0079) 0022B678: 00C8EFBE (m6809_base_device::execute_run()+0x288e) 0022B6F8: 015F1A88 (device_scheduler::timeslice()+0x05a8) 0022B7A8: 01604963 (running_machine::run(bool)+0x0293) 0022F708: 015F347A (machine_manager::execute()+0x05aa) 0022F978: 0168D0CB (cli_frontend::execute(int, char)+0x0f0b) 0022FEB8: 00A55F25 (utf8_main(int, char)+0x04a5) 0022FEF8: 0195948E (wmain+0x006e) 0022FFC0: 0040140B (__tmainCRTStartup+0x028b) 0022FFF0: 7C816037 (RegisterWaitForInputIdle+0x0049)
Steps To Reproduce	Indicated in the Description. Use DOS1.1 as a ROM to see the bug. DOS1.0 may also show it.
Additional Information	This seems to have been present for several versions but I have not noticed it. First because new formatted disks can be created from the MESS menu without using the DIsk Basic command. 2) This is not seen when using the OS-9 command Format. 3) I normally use a modified disk ROM (RGBDOS) for .vhd drives and this ROM does not show the bug with floppy disk images.
Github Commit

Flags
Regression Version
Affected Sets / Systems	All sets in coco12.c, coco3.c

Attached Files

No.11814 Duke Developer Jul 3, 2015, 22:16	This bug is no longer valid since the WD controller emulation has been replaced.