06022: pitfight: Pit-Fighter - Vertical gaps in the background scenes

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
06022	Graphics	Minor	Always	Aug 30, 2015, 17:01	Apr 28, 2021, 14:05

Tester	rcoltrane	View Status	Public	Platform	MAME (Official Binary)
Assigned To		Resolution	Open	OS	Windows Vista/7/8 (64-bit)
Status [?]	Confirmed			Driver	atari/atarig1.cpp
Version	0.164	Fixed in Version		Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	06022: pitfight: Pit-Fighter - Vertical gaps in the background scenes
Description	There's some vertical gaps that appears on the background layer during gameplay. It's mostly noticeable during the Grudge Matches where you can see some vertical 'holes' that goes through the boat on the background and you can see the sea through these holes.
Steps To Reproduce	Just play the game until the 1st grudge match and you will spot several vertical gaps on the boat right off the bat, where you can spot the sea through these gaps.
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	pitfight

Attached Files	0000.png (20,390 bytes) Aug 30, 2015, 17:01 Uploaded by rcoltrane
Attached Files	0004.png (20,374 bytes) Aug 30, 2015, 17:03 Uploaded by rcoltrane

No.11995 NekoEd Senior Tester Aug 30, 2015, 17:33 edited on: Aug 30, 2015, 17:36	Confirmed, SDLMAME64 on Linux/x64 0.165 Additionally, there is a flash of garbage in Ty's intro in attract mode. I don't know whether or not this is related, but I'm noting it here anyway. (I've also updated the report to reflect that this is a minor bug.)
No.15924 MetalGod Senior Tester Dec 18, 2018, 12:27 edited on: Dec 18, 2018, 12:29	This is how it should look like (recorded from a pcb) 3:12
No.15926 rcoltrane Tester Dec 18, 2018, 15:22 edited on: Dec 18, 2018, 17:39	Thanks for the video MetalGod. Also, during matches 3 and 4, we can see that the squares on the wall at the back of the bar reamins visible, while in MAME they merge together sometimes. This clearly has relation to the vertical gaps bug reported here. It seems to be imprecise emulation of the hardware's scaling system or something like that.
No.15937 NekoEd Senior Tester Dec 21, 2018, 04:58	Given we're not doing this perfectly, I'll leave this confirmed.
No.17643 rcoltrane Tester May 12, 2020, 14:31 edited on: Feb 10, 2021, 23:54	Here's another PCB video recorded by a guy named "Janet" on Youtube. It's a full gameplay and has much better resolution, so we can clearly see that those vertical gaps in MAME emulation, mostly noticeable in grudge matches, are not present on the real thing. Also during the bar matches (3 and 4) we can notice that the divisions on the upper section of the bar don't merge together. in MAME, they merge together all the time.
No.18452 rcoltrane Tester Feb 10, 2021, 23:53 edited on: Feb 10, 2021, 23:55	Yet another PCB video, this time it is a japanese pcb gameplay with even better resolution/gameplay: Points to observe are the upper squares at the upper secton of the bar (they never 'merge' together as seen in mame) and the ship's "nose" on grudge matches, which never splits up as opposed to mame where it starts splitted.
No.18753 rcoltrane Tester Apr 28, 2021, 14:05 edited on: Apr 28, 2021, 14:15	Another real PCB gameplay reference recorded @60fps with decent resolution, to compare vertical gaps in a real PCB vs MAME. Some gaps exist in the real pcb as well but in a much smaller number. And the squares at the top of the screen in mathces 3 and 4 do not merge together while the game is zooming in and out. The gaps between the squares flick and their sizes vary a little, but they only merge in the real pcb when the zoom out is at the maximum. In MAME, they merge all the time in comparison.