00722: ninjakun: Garbage is shown behind the GAME OVER text

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
00722	Graphics	Minor	Always	Feb 3, 2008, 07:50	Mar 18, 2008, 09:27

Tester	-MAME Source-	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	Bugs That Aren't Bugs	OS
Status [?]	Resolved			Driver	upl/nova2001.cpp
Version	N/A	Fixed in Version		Build	Debug
		Fixed in Git Commit		Github Pull Request #

Summary	00722: ninjakun: Garbage is shown behind the GAME OVER text
Description	When the game ends, GAME OVER is written at the center of the screen, and garbage characters are displayed in the background behind it.
Steps To Reproduce
Additional Information	The game attempts to display character 0x20 in the background tilemap, suggesting that it wants to draw a space. However, character 0x20 is not a space in the bg character set. Added by Nicolasa
Github Commit

Flags	Noted in Source
Regression Version
Affected Sets / Systems	ninjakun

Attached Files	0004.png (3,151 bytes) Feb 14, 2008, 15:14
	0001.png (2,624 bytes) Mar 10, 2008, 17:48
	ninjakun_0123u5.png (3,055 bytes) Mar 17, 2008, 19:32

No.00010 Fujix Administrator Feb 9, 2008, 13:00	Can't repro in 0.123. Already fixed?
No.00083 nicolasa Developer Mar 10, 2008, 13:09	For me it happens identically in 0.123u4. Can you post a screenshot?
No.00085 Tafoid Administrator Mar 10, 2008, 15:56	It reproduces as screenshot shows here in 0.123u4.
No.00086 robiza Developer Mar 10, 2008, 17:40 edited on: Mar 10, 2008, 17:48	it's nova2001.c driver not ninjakid.c driver in the second stage the bug is not present
No.00203 Fujix Administrator Mar 17, 2008, 19:46	I found why. I went into the second stage. It seems that once the background is displayed correctly, it works normally also in the first stage.
No.00217 nicolasa Developer Mar 18, 2008, 09:27	This appears to be a bug in the game code. The background if the GAME OVER box is drawn using color 15. The corresponding palette entries are cleared to black between levels while rendering the sky rainbow effect. However, they are not cleared before level 1, so whatever was left there will be shown in the GAME OVER box. This can be the bootup RAM test garbage, if playing right after boot, or the geisha image shown during attract mode. So ending the game on level 1 will always show garbage in the GAME OVER box, unless the game is started immediately after another one which finished on a level greater than 1, without letting the attract mode loop.