03819: pitfight and clones: NVRAM high scores table not working properly

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
03819	Misc.	Minor	Always	Apr 22, 2010, 18:59	Apr 27, 2010, 21:54

Tester	rcoltrane	View Status	Public	Platform	MAMEUI
Assigned To		Resolution	No change required	OS	Windows XP (32-bit)
Status [?]	Closed			Driver	atari/atarig1.cpp
Version	0.137	Fixed in Version		Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	03819: pitfight and clones: NVRAM high scores table not working properly
Description	After achieving 5 or more high score records, when you quit the game it keeps only the first 4 scores recorded.
Steps To Reproduce	Make more than 5 high scores entries and quit the game. Start it again and it will keep only your 4 highest scores recorded.
Additional Information	Tested only with the parent set (pitfight).
Github Commit

Flags
Regression Version
Affected Sets / Systems	pitfight and clones

Attached Files	0001.png (10,802 bytes) Apr 27, 2010, 15:20
	0003.png (10,852 bytes) Apr 27, 2010, 15:20
	savestate.zip (242,662 bytes) Apr 27, 2010, 15:22

No.05993 Tafoid Administrator Apr 22, 2010, 19:36	I assume this is expected behavior. It's normal to have an a few top scores saved and the rest in defaults - it encourages replay. Atari games, kept the top 3 to 5 scores on all their lists. You could test to see if that erasure still happens if you set in Service Mode (F2): GAME OPTIONS > AUTO CLEAR HIGH SCORES > Set to OFF (it's default ON) and save the option change as detailed on screen.
No.06014 Tafoid Administrator Apr 26, 2010, 17:49	Does anyone want to test this. I have no desire to try to get 5 high score achievable scores.. I will if I have to - but.. :P
No.06015 Fujix Administrator Apr 27, 2010, 15:25	Here I tested it. The fifth my score is removed, and previous default hi-scores are restored.
No.06016 Tafoid Administrator Apr 27, 2010, 15:31	Was this with or without the AUTO CLEAR HIGHSCORES set to OFF?
No.06017 Haze Senior Tester Apr 27, 2010, 16:57	it's almost certainly by design for the reasons Tafoid states
No.06018 Tafoid Administrator Apr 27, 2010, 21:42 edited on: Apr 27, 2010, 21:42	The game saves the top 4 scores only with AUTO CLEAR=OFF off as well. With that setting on, I expect, as the manual states "Automatically clears the high score table periodically". Again, it's not uncommon that games (especially Atari) only save the first few scores between reboots. I'm hoping someone with a running machine at KLOV can help with some hands-on observation of the high score list.
No.06019 Tafoid Administrator Apr 27, 2010, 21:52 edited on: May 31, 2012, 05:02	I'm convinced by this video someone took of his board and completing the game (3 parts) that this TOP 4 is expected behavior. Below is part 3 which shows the high score screen after finishing a game at about 8:04 for a few seconds. You can clearly see there is a TOP 4 .. which his score barely in the 5th slot. Notice all the rest are defaults. Not a Bug. Part 1: Part 2: Part 3: