05004: Parents that Use Sample Sets of the Same Name (005, 3bagflvt, armora, etc): Seems Odd that Parent (non-Clone) Sets have the "sampleof" Attribute of the Same Name Associated with Them

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
05004	Documentation	Minor	Always	Sep 17, 2012, 03:50	Sep 18, 2012, 02:15

Tester	pjo6245	View Status	Public	Platform	MAME (Official Binary)
Assigned To		Resolution	No change required	OS	Windows XP
Status [?]	Closed			Driver
Version	0.146	Fixed in Version		Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	05004: Parents that Use Sample Sets of the Same Name ( 005, 3bagflvt, armora, etc): Seems Odd that Parent (non-Clone) Sets have the "sampleof" Attribute of the Same Name Associated with Them
Description	Parents (non-Clone) sets have the "sampleof" attribute named the same as the parent associated with them that is viewable by outputting the xml listing. Three examples are 005, 3bagflvt and armora.
Steps To Reproduce	mame -listxml > mame.xml
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	Parents that Use Sample Sets of the Same Name (005, 3bagflvt, armora, etc)

Attached Files

No.08900 Tafoid Administrator Sep 17, 2012, 07:40	Is this report only written because CLRMAME alerts you to a problem? This is not a bug that I can tell. The handling of samples was changed in 0.145u1 to show in xml explicitly which sets was the parent for EVERY rom, even those considered "parents". Rewrote SAMPLES as a modern device. Updated all callers. FLAC reading is now done using the FLAC wrapper. There is now a samples_iterator class to centralize the logic for handling the sample list walking. [Aaron Giles] Before, if an XML entry had samples and had no "sampleof=" entry, it was assumed a parent. The additional sampleof entries make it easier and more obvious which sample sets act as parent sets. CLRMAME's problems are not MAME's problems, in my honest opinion and that is the only place I know of where this new functionality throws up an issue.
No.08902 pjo6245 Tester Sep 17, 2012, 17:50 edited on: Sep 17, 2012, 17:52	Greetings Tafoid. I missed this entry in the whatsnew.txt for 0.145u1. Actually, I use three less known tools: GordonJ's RomVault, Andrea Mazzoleni's AdvanceScan and logiqx's DatUtil which do not work with the sampleof reference direct to a parent. This begs the question: Do you think there should be a diskof attribute? Thank you. Pat
No.08904 NekoEd Senior Tester Sep 17, 2012, 23:02	Problems in external utilities caused by updates or upgrades ro MAME's XML output aren't MAME bugs and should be taken up with the authors of the external utilities.
No.08905 pjo6245 Tester Sep 18, 2012, 00:48	Greetings BarnacleEd. I agree this issue is an observation and to it being closed. Thank you. Pat