08410: neogeo.cpp: Wrong screenshot file names in systems with multiple carts (software list)

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08410	Core	Feature	Always	Sep 7, 2022, 06:56	Sep 18, 2022, 19:59

Tester	Foxhack	View Status	Public	Platform	MAME (Official Binary)
Assigned To		Resolution	No change required	OS	Windows 10/11 (64-bit)
Status [?]	Closed			Driver	neogeo/neogeo.cpp
Version	0.247	Fixed in Version		Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	08410: neogeo.cpp: Wrong screenshot file names in systems with multiple carts (software list)
Description	This affects software list systems that can have more than one game loaded. My example involves the neogeo. Snapname is configured to '%g/%d_cart1%i', which will output the filename correctly. So for example if I load "mame neogeo aof", the filename will go to neogeo\aofxxxx.png. But if you load more than one cart, the screenshot will always have the name of the very first cart specified in the command line option. For example, running "mame neogeo -cart1 aof -cart2 burningf -cart3 aof3", will make screenshots be output to neogeo\aofxxxx.png. Two more examples, "mame genesis -cart1 sk -cart2 sonic2" - the filename will be genesis\skxxxx.png. "mame genesis -cart1 ggenie -cart2 sonic2" - filename is genesis\ggeniexxxx.png. My suggestion is that in this case, the names of all the games loaded into the system be used to create the base filename. So something like genesis\ggenie+sonic2xxxx.png in the last example above. I only tried this with cart-based systems, I don't have much experience working with floppy based systems, but I assume there are similar problems there.
Steps To Reproduce	Load a game system with more than one game.
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	neogeo.cpp

Attached Files	ggenie0000.png (90,237 bytes) Sep 7, 2022, 06:56 Uploaded by Foxhack Example of screenshot with wrong file name

No.20520 Tafoid Administrator Sep 9, 2022, 21:30	This overall seems more of a desired feature than strictly a bug in my eyes - but I'll leave it open for direction.
No.20532 Foxhack Tester Sep 12, 2022, 18:26	I tried to see if I could add this on my own, but couldn't. Frankly, this would be better as a desired feature rather than a bug. I don't think anyone thought this would be necessary back in the day... so yeah, I'm okay with this being flagged as 'desired feature' instead.
No.20541 cuavas Administrator Sep 18, 2022, 00:29	Trying to do this would just over-complicate things. You'll just have to organise your screenshots manually.