Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
08851 Media Support Major Always 20 days ago 18 days ago
Tester pnp2084 View Status Public Platform MAME (Official Binary)
Assigned To pnp2084 Resolution Fixed OS Windows 10/11 (64-bit)
Status [?] Resolved Driver
Version 0.264 Fixed in Version 0.265 Build 64-bit
Fixed in Git Commit e2b3371 Github Pull Request #
Summary 08851: trs80l2 trs80m3 trs80m4 coco: DMK Disk format detection rejects single-sided DMK files
Description MAME fails to identify single-sided DMK disk image files and rejects loading them.
Steps To Reproduce Try to load a DMK file e.g.
mame -w trs80m3 -flop1 TRSDOS13.dmk

Results in:
Fatal error: Device 5.25" double density floppy drive load failed: Unable to identify image file format
Additional Information At least one problem: dmk_dsk.cpp checks for byte 4 to be zero but that byte contains flags (e.g. single-sided)
The "i =4" below should be "i = 5"
for (int i = 4; i < 0x10; i++)
{
    if (header[i] != 0x00)
        return 0;
}
Introduced by wilbertpol in this commit:
https://github.com/mamedev/mame/commit/699b8b5345061216c29e2ebdc5bb7e38350b048e

There may be other problems but this is the most likely.
Github Commit
Flags
Regression Version
Affected Sets / Systems trs80l2 trs80m3 trs80m4 coco
Attached Files
zip file icon trsdos13.zip (39,118 bytes) 20 days ago Uploaded by pnp2084
TRSDOS OS version 1.3 for TRS-80 Model III
Relationships
There are no relationship linked to this issue.
Notes
1
User avatar
No.22054
Robbbert
Senior Tester
20 days ago
edited on: 17 days ago
Confirmed.