01598: pacmanbl: Sprites are cut off on the top row

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
01598	Graphics	Minor	Always	Mar 23, 2008, 21:45	Oct 27, 2010, 16:23

Tester	Robbbert	View Status	Public	Platform
Assigned To		Resolution	Reopened	OS
Status [?]	Confirmed			Driver	galaxian/galaxian.cpp
Version	0.116u3	Fixed in Version		Build
		Fixed in Git Commit		Github Pull Request #

Summary	01598: pacmanbl: Sprites are cut off on the top row
Description	Sprites are cut off on the top row
Steps To Reproduce	Formerly driver galaxian.c (changed in 0.124u1)
Additional Information	Split from original bug pacmanbl0116u3yel. 00445 Fixed in 0.124u1 for pacmanbl. The other sets that have Ghost Muncher (4in1 and gmgalax) still show the old behavior because of not being transitioned to the new code. 0.126u1: pacmanbl regression to the point which the entire top row no characters are shown (screenshot).
Github Commit

Flags
Regression Version	0.126u1
Affected Sets / Systems	pacmanbl

Attached Files	0002.png (2,820 bytes) Mar 23, 2008, 21:45
Attached Files	0.136u2 - pacmanbl.png (4,363 bytes) Feb 14, 2010, 02:22

No.00834 Tafoid Administrator Apr 28, 2008, 18:09	4in1 and gmgalax still show this bug behavior due to not being moved over to the new galdrvr.c as of yet.
No.00837 Haze Senior Tester Apr 29, 2008, 16:20	there is some reason to believe that the real hardware might actually cut these lines off.. the fix that was added to the other driver is more of a kludge.. somebody with the boards could do with confirming tho
No.05712 Tafoid Administrator Feb 14, 2010, 02:23	Reopened based on post: http://www.mameworld.info/ubbthreads/showthreaded.php?Cat=&Number=214213
No.06808 CrazyKongFan Tester Oct 25, 2010, 18:05	OK, I just got a working Pac-Man bootleg board. I had to figure out some wires on the pinout, and although I don't know if I have the colors correct (couldn't find a pinout for the PCB that matched exactly), the rest of the game plays as intended. It plays and sounds just like the pacmanbl romset when you play it, so I'm assuming that's the version it is (I haven't dumped the ROMs yet). Anyway, it appears that the maze itself is shifted several pixels down in the current version of MAME and that's what's causing everything to disappear on the top of the maze. On my board, when you go on the top row, you lose the top of Pac-Man and the ghosts, just like it used to do before it was "fixed" ;) I can take some pics of it running and upload them here (and like I said, the colors may be off because I might have the RGB wires to the monitor mixed up) if that'll help.
No.06809 Tafoid Administrator Oct 25, 2010, 18:28	Welcome aboard, CrazyKongFan. Anything you can provide for reference would be great .. an audio snippet of the intro fanfare and some of the game .. some snaps or a small movie of the gameplay and the showing of the partially cut off ghosts would be great too. Whatever you can do, is welcomed :)
No.06820 CrazyKongFan Tester Oct 27, 2010, 16:23 edited on: Oct 30, 2010, 15:05	Don't know if I can do video, but I can do pics. For video, all I have is a super cheesy video camera from a casino giveaway, but it will only do about 30 seconds with the built in memory, and it doesn't look very good when I record it :( I did dump the ROM's, and they match up perfectly with an old set of pacmanbl (I assume those haven't changed...my eprom reader is on a very old PC, since it requires an ISA slot! And I tested them with an old version of MAME on that PC). I also tried all 8 combinations of the RGB wires and didn't come up with anything that matched the colors in MAME, so I guess mine has different data on the color prom. I don't know where it's located on the board though, and I doubt my reader can read it anyway. OK, for some useful info. I did notice on my board, the top row of pixels on both the ghosts and Pac-Man are on the same row as the bottom row of pixels on the maze edges (when going horizontal) Also, the right side of Urchin and Romp overlap the left edge of the maze by 1 pixel, Stylist has no gap between his right and the left edge of the maze (but doesn't overlap) and Crybaby is centered in the maze when going up/down, with a 1 pixel gap on either side of him. The same holds true when they're turned blue (except for Urchin. He shifts over left 1 pixel during blue time). Also, It's hard to tell since I can't pause it and it's on old CRT, but along the top, where they partially disappear, it appears the top row of pixels on the ghosts eyes are the lowest part that's not visible. An easier way to tell, when they're blue and in the top row, you should see one row of pixels above their eyes. As to the sound, don't change a thing! :) Putting my laptop right next to the speaker from the PCB and running them simultaneously, they sound almost identical (at least to my ears). I'll try and get some pics uploaded soon. EDIT: Upon further research, I fixed the above description of where Crybaby is located. He has no left/right pixel offset when going up or down, and is located where he actually should be, if it were a real Pac-man board. I also noticed Urchin moves over 1 pixel to the left (so he's at the edge of the maze, but not overlapping it) during blue time (and made an edit above). Doesn't matter whether he's blue or not, but if he's running vertically, you can see him shift over 1 pixel to the right as soon as blue time ends. The normal version of MAME I use is WolfMAME 106, and the side to side pixel offsets are correct on that one, but they're not overlapping at the top of their sprites with the bottom pixel of the maze. Not sure when that was changed, but it's still wrong in the current version (140)