Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
01668 DIP/Input Major Always Apr 4, 2008, 10:32 Apr 8, 2008, 17:34
Tester LastNinja2 View Status Public Platform MAME (Official Binary)
Assigned To Resolution Fixed OS Windows XP/Vista 32-bit
Status [?] Resolved Driver
Version 0.124a Fixed in Version 0.124u2 Build Normal
Fixed in Git Commit Github Pull Request #
Summary 01668: condor, griffon, vautour2: Games' controls are broken
Description Three clones of Phoenix (condor, griffon, vautour2) have a strange control problem: the ship is always heading left. Oddly enough, you must keep the left direction to actually make the ship go right.
Steps To Reproduce
Additional Information Fix submitted by etabeta/stephh to MAMEDEV for 0.124u2
Github Commit
Flags
Regression Version
Affected Sets / Systems condor, griffon, vautour2
Attached Files
 
Relationships
There are no relationship linked to this issue.
Notes
6
User avatar
No.00558
etabeta
Developer
Apr 4, 2008, 14:31
confirmed, found regression in 122u7 and just submitted a fix to mamedev ;)
User avatar
No.00561
Tafoid
Administrator
Apr 4, 2008, 14:37
I was in the process of posting confirmation and other info just tested. Thanks for the help.
User avatar
No.00612
stephh
Developer
Apr 8, 2008, 09:36
Fix was partially correct, so I changed some things (and made some other work in the driver). I'll submit everything tonight.
User avatar
No.00614
etabeta
Developer
Apr 8, 2008, 12:12
edited on: Apr 8, 2008, 12:13
thanks. i simply reverted a wrong change in condor inputs (from ACTIVE_HIGH to ACTIVE_LOW) and that was enough to fix this regression.

would you mind to explain a bit further what was still missing? I'd like to improve my submissions ;)
User avatar
No.00615
stephh
Developer
Apr 8, 2008, 13:25
You forgot to add the fake "CAB" Dip Switch, so you can't set the Cabinet to "Cocktail" (and use player 2 inputs), and "Coinage" Dip Switch doesn't work anymore ...

What I also did is :

  - use port tags instead of port number (so you can put the ports in any order and easily use the PORT_INCLUDE macro)
  - try to use AM_READ_PORT and PORT_CUSTOM macros instead of specific ports read handlers ('survival' still needs to be changed but the game isn't working)

As Aaron changed some function names, wait for 0.124u2 to see what I have done ... Then, (more) questions and comments will be welcome :)
User avatar
No.00619
etabeta
Developer
Apr 8, 2008, 16:46
I will for sure, thanks. The fake Cab dip and the coinage dip were my mistake (next time I'll triple check both the code and the compiled exe before submitting)

sorry for the incomplete patch