01845: all games: cheats are broken

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
01845	Cheat System	Major	Always	May 29, 2008, 17:48	Jun 5, 2008, 09:57

Tester	Mamesick	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	Fixed	OS	Windows XP/Vista 32-bit
Status [?]	Resolved			Driver
Version	0.125u3	Fixed in Version	0.125u4	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	01845: all games: cheats are broken
Description	Cheats are broken in all games. The "Enable/Disable A Cheat" menu is always empty and you can only go back to main menu.
Steps To Reproduce	Launch a game with -cheats option enabled, then enter in the TAB menu and choose "Cheats". So go into "Enable /Disable A Cheat" too see what happens.
Additional Information	Official cheat file from Pugsy's site.
Github Commit

Flags
Regression Version	0.125u3
Affected Sets / Systems	all games

Attached Files	Appunti01.jpg (262,780 bytes) May 30, 2008, 17:40
Attached Files	blktiger_cheat_codes.txt (712 bytes) May 30, 2008, 17:46 [Show Content]

No.01127 Tafoid Administrator May 29, 2008, 18:54	There may be a set up process we are missing, but out of the box MAME and the latest cheat.dat do not jive. I have to assume the new cheat engine has possibly different fields than the old cheat.dat - so modification of the .dat might be needed to comply?
No.01134 Tafoid Administrator May 29, 2008, 23:04	There are many serious problems with -cheat that don't seem to be fixable on the user end. Confirming.
No.01141 ShimaPong Tester May 30, 2008, 16:16	1st of all, this is deep update (and now in the making) so that many bugs/problems will be included. But half of this problem is new cheat system and half is database problem (= not MAME bug). Have you checked new cheat format code? Try the following code. > [ Star Force ] >starforc:81000010:0298:0000008E:FFFFFFFF:Rapid Fire >starforc:81000010:1848:000000C9:FFFFFFFF:Invincibility >starforc:00006000:83F5:000000F0:00010002:Select Speed >starforc:00006800:83A3:000000F0:00140003:Select Bullet Speed Operation core on new cheat system is adjusted with new cheat format so that old(older) code requires to test or convert to new. (Main problem is that current system can't reproduce several old format due to limited type field) > The "Enable/Disable A Cheat" menu is always empty and you can only go back to main menu. What message is displayed? If an empty, cheat system tells why no cheat code though. And please post a sample code together. I don't know in case that only simple report, "cheat code doesn't be read. I use official database". Because the cheat code includes many different operations/options/flags so I fail to identify the cause of a problem.
No.01143 Mamesick Senior Tester May 30, 2008, 17:43 edited on: May 30, 2008, 17:47	I attached a pic of "Enable/Disable A Cheat" menu. It's the same for the majority of games I tested. Are you in the mood to rewrite the whole database with your new code? Seriously, the new cheat code looks like isn't able to read and display old cheats from official database. I attached blktiger codes as an example.
No.01144 ShimaPong Tester May 30, 2008, 18:23	It's mysterious screenshot. It has 10 specified separators and the sample codes you attached is the same number so that CODES ARE LOADED WITHOUT PROBLEM. But special separator is only for new format ... OK, I understand about this bug. Check these codes in "Add/Edit a Cheat" menu. Is it displayed as expected?
No.01148 Mamesick Senior Tester May 30, 2008, 19:19	In "Add/Edit a Cheat" the name of the cheats is displayed correctly. But if I select a cheat and then press enter, nothing happens. I'm not able to edit it. Hope this helps.
No.01155 ShimaPong Tester May 31, 2008, 16:02	Edit menu is too huge code so that I have not finished converting name based on guidlines. Force to convert old code to new. If you DEBUG build, select "convert" item in add/edit command menu. Or by hand. Conversion is simple. Chage first ":" in a line to ">" So... ":blktiger:..." -> ">blktiger:..."
No.01194 aaron Developer Jun 5, 2008, 09:57	by ShimaPong