02146: ojankohs: Impossible to display the full contents of a long string of comment cheats

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
02146	Cheat System	Minor	Always	Aug 22, 2008, 08:53	Sep 11, 2008, 14:46

Tester	Pugsy	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	No change required	OS
Status [?]	Closed			Driver
Version	0.127	Fixed in Version		Build	C2D
		Fixed in Git Commit		Github Pull Request #

Summary	02146: ojankohs: Impossible to display the full contents of a long string of comment cheats
Description	If a cheat has got a LOT of comment cheats strung together (like many Majhong games) it's impossible to display the entire list - it will jump straight to the end. The original info can be found here:- http://cheat.retrogames.com/forums/viewtopic.php?t=3110 It's not really necessary or wanted to be able to move through comments one comment line at a time but it is necessary to at least be able to view all the comments. Maybe a page down/up function if the first/last cheat entry on display is a comment cheat and all the remaining cheat entries in that cursor direction to the top/bottom of the displayed cheats are comments?
Steps To Reproduce	Use the xml cheat file collection from here and copy it to the MAME dir:- http://cheat.retrogames.com/forums/viewtopic.php?t=3110 mame ojankohs -cheat You can't see all these comments which exist in the xml file:- [ Here is the look-up list for ] [ the above watches. ] [ ] [ value common name chinese name ] [ ??h - no tile - ] [ 00h 1 'characters' 1 'wan' ] [ 01h 2 'characters' 2 'wan' ] [ 02h 3 'characters' 3 'wan' ] [ 03h 4 'characters' 4 'wan' ] [ 04h 5 'characters' 5 'wan' ] [ 05h 6 'characters' 6 'wan' ] [ 06h 7 'characters' 7 'wan' ] [ 07h 8 'characters' 8 'wan' ] [ 08h 9 'characters' 9 'wan' ] [ 10h 1 'dots' 1 'tung' ] [ 11h 2 'dots' 2 'tung' ] [ 12h 3 'dots' 3 'tung' ] [ 13h 4 'dots' 4 'tung' ] [ 14h 5 'dots' 5 'tung' ] [ 15h 6 'dots' 6 'tung' ] [ 16h 7 'dots' 7 'tung' ] [ 17h 8 'dots' 8 'tung' ] [ 18h 9 'dots' 9 'tung' ] [ 20h 1 'bamboo' 1'tiao/Bird' ] [ 21h 2 'bamboo' 2 'tiao' ] [ 22h 3 'bamboo' 3 'tiao' ] [ 23h 4 'bamboo' 4 'tiao' ] [ 24h 5 'bamboo' 5 'tiao' ] [ 25h 6 'bamboo' 6 'tiao' ] [ 26h 7 'bamboo' 7 'tiao' ] [ 27h 8 'bamboo' 8 'tiao' ] [ 28h 9 'bamboo' 9 'tiao' ] [ 30h East 'wind' ] [ 31h South 'wind' ] [ 32h West 'wind' ] [ 33h North 'wind' ] [ 34h White 'dragon' ] [ 35h Green 'dragon' ] [ 36h Red 'dragon' ]
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	ojankohs

Attached Files	cheat.zip (1,146 bytes) Aug 22, 2008, 10:10
Attached Files	ojankohs.png (154,429 bytes) Aug 22, 2008, 11:01

No.02168 etabeta Developer Aug 22, 2008, 10:11	attached a cheat.zip containing only ojankohs.xml, to make testing/fixing easier
No.02173 ShimaPong Tester Aug 22, 2008, 15:27	I think it's a specification. Therefore a code creator gives due consideration to this problem and should write a comment. But it's not better to mix a cheat code and long comment in the same menu. Because MAME in-game menu is very limited so that sometimes long comment prevents from selecting a code. ...Or display (long) comment in another window like extend comment view in previous system.
No.02216 aaron Developer Aug 26, 2008, 04:46	This is by design, really. The use of pages and pages of comments is not really supported by the menu system. If you need to display that much explanatory text, it would be better to have something you can toggle on and off that displays the information via output tags.