Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
02165 Core Major Always Aug 26, 2008, 17:58 Aug 27, 2008, 08:43
Tester john_iv View Status Public Platform MAMEUI
Assigned To Resolution Won't fix OS Windows XP/Vista 64-bit
Status [?] Closed Driver
Version 0.127 Fixed in Version Build 64-bit
Fixed in Git Commit Github Pull Request #
Summary 02165: Various: Some clone roms unable to be stored in Mame's full merge mode due to same name for different roms.
Description This is a list of clones in Mame that have the same name referring to different roms, this makes it impossible to merge them into their parent set when using Mame's full merge mode.

These roms need to be renamed to allow for proper storage in full merge mode into their parents. BrianT? :-)

Clone with bad names / Parent

buckrogn / buckrog
couplei / couple
couplep / couple
ctribe1 / ctribe
ddgn6809 / ddragon
ddrago3j / ddragon3
defendw / defender
esha / esh
euro2k2a / euro2k2
freezea2 / freeze
freezea3 / freeze
freezea4 / freeze
freezea5 / freeze
freezea6 / freeze
jojoalt / jojo
mocapbj / mocapb
p911j / p911
punchita / punchout
rastanu / rastan
rastsaga / rastan
sfiii3an / sfiii3
sidebs2j / sidebs2
sogeki / sscopex
spacedxj / spacedx
suprmria / suprmrio
thayersa / thayers
thrild2a / thrild2
trvmstrb / trvmstr
wcombaj / wcombat
wcombak / wcombat
Steps To Reproduce
Additional Information
Github Commit
Flags
Regression Version
Affected Sets / Systems Various
Attached Files
 
Relationships
There are no relationship linked to this issue.
Notes
10
User avatar
No.02227
Fujix
Administrator
Aug 26, 2008, 18:38
edited on: Aug 26, 2008, 18:41
In fact this issue used to be listed as romcrc0109ora:

List of ROMs of the same name with different CRC:

- 1.1d in couple (couple.c)
couple: bc70337a
cpuplep: 4601ace6
couplei: 760fa29e

- palce16v8-d72-10.ic12 in spacedx (taito_b.c)

spacedx: a5181ba2
spacedxj: a01c8336

- cpu-ic3 in buckrog (turbo.c)

buckrog: f0055e97
buckrogn: 7f1910af

It's not found here now tho.
I'd like Dev team's policy on this.
User avatar
No.02228
etabeta
Developer
Aug 26, 2008, 19:47
I think MAME should use the name used on labels in the pcb, so if they're the same on the board they must be the same in MAME

the merged sets handling could be done by the rommanagers, which could append something at the end of the filename to distinguish between each of them

the renamed roms should work with no problems since MAME can load by crc
User avatar
No.02229
Tafoid
Administrator
Aug 26, 2008, 19:53
Agreed. I was about to post pretty much the same thing as etabeta...
This to me is more of a FEATURE request than a core problem - the documentation aspect of MAME presupposes that the filename, when possible, will match that of the chip label or actual part number of the rom. Since MAME loads by CRC, filenames don't matter and are an issue for the rom managers (which clrmame handles seemingly fine).
User avatar
No.02232
john_iv
Senior Tester
Aug 26, 2008, 20:08
edited on: Aug 26, 2008, 20:10
I understand the arguments, but on the flip side it is not possible to reconcile this with one of Mame's built in storage techniques.

So either that needs to be altered by dropping fully merged support and going to a forced full split mode or perhaps allowing nested folders w/in the parent zip w/ the files stored that way so they don't collide.

Clrmame does complain about them though these days and forces a decouple of the parent/clone relationship so you end up w/ the clone existing separately, defeating the purpose of full merge mode.
User avatar
No.02233
etabeta
Developer
Aug 26, 2008, 20:14
edited on: Aug 26, 2008, 20:14
Well, you can reconcile them: you manually rename those files to something different and you put them in the merged sets. At that point MAME shall be able to load the correct files from the crc, no matter the filename (iirc the priorities at loading)
User avatar
No.02234
aaron
Developer
Aug 26, 2008, 20:55
There is no "MAME Full Merge Mode". We happen to support looking in the parent for a match if not present. It so happens that mostly this allows you to merge all clones into the parent, but it is a side-effect, not a special mode. If the names clash then sorry, the side-effect is that a full merge is not possible for the set in question.

If the proper solution is to stop looking in the parent, I can do that, but I doubt that's what anyone really wants.
User avatar
No.02236
john_iv
Senior Tester
Aug 27, 2008, 01:02
edited on: Aug 27, 2008, 04:33
Hmm, I'm torn. If a full merge across all games is no longer possible I would contend that the feature/implementation falls short of the bar even if it's a side effect and we should go to only supporting split-merge in clrmame parlance [parent.zip exists w/ its common roms and its clones exist as zips w/ their separate roms] or full-split [every rom duplicated in separate.

[Update: Well, went split merged so it's academic now. :-)]
User avatar
No.02237
Robbbert
Senior Tester
Aug 27, 2008, 05:56
I have used fully-merged sets for some years now, mainly to save space and directory entries. The rom manager that I use (a homebrew that I made), renames all roms to their CRC (the CRC is the filename), thus avoiding clashes.

There's nothing to say that you have to use the filename specified in MAME, it's just that ClrMamePro insists on it, rather than being flexible.

Personally, I don't believe it's the dev's responsibility to look out for clashes; the user has to sort that out for themselves.
User avatar
No.02238
Firewave
Senior Tester
Aug 27, 2008, 08:13
It's a clrmamepro option and not a MAME feature. It just tries to utilize MAME's abilities to the biggest extent. It also detects such clashes and still gives you the best possible fully-merged sets, so you don't even have to concern about those. Maybe you find something, that's more convenient for you and convince Roman to implement it after his vacation ;)
And keep in mind ...not long ago a convenience feature has been removed from clrmamepro, because it caused issues (nodump fillers).
User avatar
No.02239
Robbbert
Senior Tester
Aug 27, 2008, 08:43
I'm happy with what I have, and ClrMamePro isn't the only rom manager around. What happens with it doesn't concern me.

However, I agree with the removal of the nodump fillers, it was only ever there to keep the rom kiddies happy.