Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
02503 Cheat System Minor Always Oct 9, 2008, 03:07 Oct 10, 2008, 12:55
Tester cibomatto2002 View Status Public Platform MAME (Official Binary)
Assigned To Resolution No change required OS Windows XP/Vista 32-bit
Status [?] Closed Driver
Version 0.127u6 Fixed in Version Build Normal
Fixed in Git Commit Github Pull Request #
Summary 02503: xml parse error is reported when "--" is in a comment clause.
Description When I run kof99 I get the error kof99n.xml(28):error parsing XML (not well-formed (invalid token))
Steps To Reproduce Start the game
Additional Information Originally reported for kof99 issue, but it is a general xml parsing problem. I removed Affected Sets.
Github Commit
Flags
Regression Version
Affected Sets / Systems
Attached Files
jpg file icon Capture10-8-2008-9.52.58 PM.jpg (43,218 bytes) Oct 9, 2008, 03:07
Relationships
There are no relationship linked to this issue.
Notes
8
User avatar
No.02722
Fujix
Administrator
Oct 9, 2008, 06:50
If the cheat parse error appeared, it means your cheat file is broken. Not mame's fault.
And I don't confirm the error with the latest beta cheat pack by Pugsy.

Your cheat file is broken.
User avatar
No.02729
Tafoid
Administrator
Oct 9, 2008, 15:22
edited on: Oct 9, 2008, 17:08
I get the error on the console window after quitting the game (either kof99 or kof99n) using anything 0.127 or later. But, as Fujix mentions, the problem seems to lie in the XML being malformed and not in MAME. Repoirt this error the Pugsy's Cheat forum instead. If this turns out to be a MAME issue, we can reopen it.

cibomatto2002, Please heed this reminder.
Normal MAME builds, even when running in a window do not pop-up error messages like your screen shows. Avoid reporting any bugs that have not been verified to happen on the baseline version from http://www.mamedev.org or a self-built version from original MAMEDEV sources. This means: no reports from MAMEUI, MAMEUIFX, MAMEPLUS, MAME++, MAMENeht, MAME Ash build, MAME Houba or whatever else you may be using. Tracking bugs from unofficial versions based on the difference in sources are often a waste of time for everyone and serve only to irritate those who must test/verify your claims.
User avatar
No.02731
Fujix
Administrator
Oct 9, 2008, 18:07
edited on: Oct 9, 2008, 18:12
Sorry for inconvenient. I confirmed the issues with the "really" latest cheat.zip.
The problematic line is
<!-- :kof99:60000000:000000:00000000:00000000:----------------------------------------------------------------------- -->

I found putting "--" between a comment clause causes the error, MAME may consider it as a beginning of "-->". Any of these examples will be an error in MAME.
<!-- -- -->
<!-- abc--abc -->
<!-- --->
(I don't check the xml specifications yet and I'm not sure if the last one is allowed or not.)
User avatar
No.02740
cibomatto2002
Viewer
Oct 10, 2008, 04:54
OK sorry I do not think I'M a good MAME BETA tester
User avatar
No.02742
aaron
Developer
Oct 10, 2008, 05:27
MAME doesn't control the XML parsing; that is part of the expat library. So whatever it says is valid is correct as far as MAME is concerned.
User avatar
No.02743
Fujix
Administrator
Oct 10, 2008, 05:49
I set this as a BTANB for the time being.
User avatar
No.02745
Duke
Developer
Oct 10, 2008, 11:08
"For compatibility, the string "--" (double-hyphen) must not occur within comments."

http://www.w3.org/TR/REC-xml/
User avatar
No.02746
etabeta
Developer
Oct 10, 2008, 12:32
edited on: Oct 10, 2008, 13:48
reported to Pugsy

EDIT:
a new version of the cheat pack is available @ Pugsy's forums, with the comments format fixed