- --
Viewing Issue Advanced Details
[ Jump to Notes ]
ID | Category [?] | Severity [?] | Reproducibility | Date Submitted | Last Update |
---|---|---|---|---|---|
02658 | Interface | Feature | N/A | Nov 20, 2008, 15:29 | Dec 4, 2008, 13:33 |
Tester | NekoEd | View Status | Public | Platform | |
Assigned To | Resolution | Fixed | OS | ||
Status [?] | Resolved | Driver | |||
Version | N/A | Fixed in Version | 0.128u5 | Build | |
Fixed in Git Commit | Github Pull Request # | ||||
Summary | 02658: Supplement game status reports with yellow screen | ||||
Description | Thinking about how games that have serious issues/don't work are presented with a red screen mentioning so, I suggest use of a yellow screen to indicate lesser issues, such as GAME_IMPERFECT_(whatever).... I think of this after realizing that it can be easy to miss/forget/skip such report when it's colored blue like the rest of the screens.... | ||||
Steps To Reproduce | |||||
Additional Information | |||||
Github Commit | |||||
Flags | |||||
Regression Version | |||||
Affected Sets / Systems | |||||
Attached Files
|
uiyellow.diff (598 bytes) Nov 24, 2008, 15:24 [Show Content] [Hide Content]--- src/emu/ui.c 2008-11-24 10:15:57.000000000 -0500 +++ src/emu/OLD_ui.c 2008-11-24 10:11:05.000000000 -0500 @@ -290,8 +290,6 @@ if (show_warnings && astring_len(warnings_string(machine, messagebox_text)) > 0) { ui_set_handler(handler_messagebox_ok, 0); - if (machine->gamedrv->flags & (GAME_WRONG_COLORS | GAME_IMPERFECT_COLORS | GAME_IMPERFECT_GRAPHICS | GAME_IMPERFECT_SOUND | GAME_NO_SOUND)) - messagebox_backcolor = UI_YELLOWCOLOR; if (machine->gamedrv->flags & (GAME_NOT_WORKING | GAME_UNEMULATED_PROTECTION)) messagebox_backcolor = UI_REDCOLOR; } | ||||
uiyellow_pt2.diff (520 bytes) Dec 2, 2008, 16:13 [Show Content] [Hide Content]--- OLD_uimenu.c 2008-12-02 11:09:05.000000000 -0500 +++ uimenu.c 2008-12-02 11:09:33.000000000 -0500 @@ -3393,6 +3393,8 @@ /* draw a box */ color = UI_FILLCOLOR; + if (driver != NULL && (driver->flags & (GAME_IMPERFECT_GRAPHICS | GAME_WRONG_COLORS | GAME_IMPERFECT_COLORS | GAME_NO_SOUND | GAME_IMPERFECT_SOUND)) != 0) + color = UI_YELLOWCOLOR; if (driver != NULL && (driver->flags & (GAME_NOT_WORKING | GAME_UNEMULATED_PROTECTION)) != 0) color = UI_REDCOLOR; ui_draw_outlined_box(x1, y1, x2, y2, color); | |||||
Relationships
There are no relationship linked to this issue. |
Notes
6
No.03104
NekoEd Senior Tester
Nov 24, 2008, 15:25
|
I have added a diff file which makes the warning box after you launch a game yellow if the game works but has emulation imperfections; if it has both imperfections and doesn't work, the box will still be red. |
---|---|
No.03109
Haze Senior Tester
Nov 24, 2008, 20:13
|
I've commited this, although that doesn't mean it will be accepted. |
No.03116
NekoEd Senior Tester
Nov 25, 2008, 00:13
|
Cool either way. I tried to do it for the Minimenu, too, but the code there seemed a bit more tangled and I didn't figure it out yet.... though I haven't really tried, either.... |
No.03195
NekoEd Senior Tester
Dec 2, 2008, 16:14
|
I've added the yellow to the minimenu now, it's in the uploaded patch uiyellow_pt2.diff |
No.03222
aaron Developer
Dec 4, 2008, 10:47
|
Resolved by Edward Swiftwood |
No.03223
NekoEd Senior Tester
Dec 4, 2008, 13:33
|
Sweet. :D |