02697: hkagerou: Inputs apparently incorrectly mapped or not mapped

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
02697	DIP/Input	Major	Always	Dec 1, 2008, 09:40	Feb 1, 2009, 20:30

Tester	nightsoil	View Status	Public	Platform	MAME (Official Binary)
Assigned To	etabeta	Resolution	Fixed	OS	Windows XP/Vista 32-bit
Status [?]	Resolved			Driver	dynax/ddenlovr.cpp
Version	0.128	Fixed in Version	0.129u3	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	02697: hkagerou: Inputs apparently incorrectly mapped or not mapped
Description	When the DIP switch labeled "Keyboard" is set to "Hanafuda", the inputs seem to behave as expected at first (i.e. you can add credits, set the bet amount, and play the game), but when you win, you find that the inputs for double-up, etc., seem to not work or be missing. When the DIP switch for "Keyboard" is set to "Mahjong", there is another problem in addition to the one mentioned above. The new problem is that the mahjong inputs, which are supposedly mapped to the letter keys, do not work. Even though the letter labels appear on the game screen, the input functions the same as in hanafuda keyboard mode, and you must use the hanafuda keys (numeric keypad) to play.
Steps To Reproduce	Play the game normally. (I assume you understand the basics of hanafuda.) When you win, the game will ask you, "W.UP or TAKE?" The inputs for "double-up" and "take" do not work. After maybe 15 or 20 seconds, the game will give up and act as though you had chosen "take". You can force the double-up game to appear without playing hanafuda. When the game is in attract mode (or, I suppose, any time), press F1 to make a menu appear. Choose "Option", then choose "W-up game". You will not be able to play the game because the controls will not work.
Additional Information	The game is hard and may require a dozen or more plays before you win.
Github Commit

Flags
Regression Version
Affected Sets / Systems	hkagerou

Attached Files

No.03192 Fujix Administrator Dec 1, 2008, 20:43 edited on: Dec 1, 2008, 20:45	Seems the input is tangled. When I set the DIP to Mahjong panel, still have to use Num Pad key even "A - G" are displayed beneath the cards. Maybe switching the input method is not implemented correctly yet. And not only the Double Up key, but also other functional keys such like Yes, No, Take, Koikoi etc don't work both in the Hanafuda panel and in the Mahjong panel.
No.03193 Fujix Administrator Dec 1, 2008, 20:51	btw, in hgokou in the same driver, the DIP option is "Number" / "Letter", although Mahjong input is mapped in this game. Maybe we can remove mahjong input from them.
No.03630 etabeta Developer Jan 23, 2009, 16:50	The problem is a bit more subtle. First of all there is a bug: what is currently labeled in UI as mahjong inputs are actually P2 inputs. That's why they didn't work On the other hand, the game uses the same input bits to read keys both in Hanafuda and Mahjong panels. I.e. the dipswitch only changes the names displayed during the game (1->6 vs. A->F), but there are no separate inputs for the different control panels. Hence, I submitted a fix which adds correctly P2 inputs and changes hkagerou to use mahjong inputs (i.e. A,B,C,D,E,F) for both players no matter the panel chosen. To help players using the Hanafuda panel, I added the Hanafuda names (1,2,3,4,5,6) to the UI menu.
No.03632 nightsoil Tester Jan 23, 2009, 18:41	What about the "double-up" and "take" inputs?
No.03633 etabeta Developer Jan 23, 2009, 19:40	my guess it's again that in MAME 0.129u2 (and older) those were P2 inputs. everything should be fixed in u3 (all the inputs now are correctly detected in the service mode, while they were not previously). if there are additional problems after u3 is out, I'm ready to re-open this bug and (more important) to look for a fix :)
No.03712 nightsoil Tester Feb 1, 2009, 20:30 edited on: Feb 1, 2009, 20:34	First, the dip switch labeled "Girl?" seems mislabeled. I have played with this switch both ways, and the girls appear either way, both in-game and as a reward screen. For those of us who wish to use these games in situations where images of semi-nude women are inappropriate, please see to it that these labels are accurate. Second, in u3 there is a conflict between the flip-flop button and the yes button. I recommend that the inputs for 1-2-3-4-5-6-yes-no be changed to A-B-C-D-E-F-M-N, which I believe is the usual arrangement when using a mahjong keyboard. (On my laptop, I use J-K-L-U-I-O-M-N.)