03090: tankbatt: Tank Battalion sound issues

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
03090	Sound	Minor	Always	Apr 2, 2009, 21:12	Aug 2, 2020, 22:17

Tester	sxevious	View Status	Public	Platform	MAME (Official Binary)
Assigned To	Ryan Holtz	Resolution	Fixed	OS
Status [?]	Resolved			Driver	namco/tankbatt.cpp
Version	0.130u2	Fixed in Version	0.224	Build
		Fixed in Git Commit		Github Pull Request #

Summary	03090: tankbatt: Tank Battalion sound issues
Description	Tank Battalion is missing the insert coin "ding" and the tank rumbling sound seems off. Compare with video of an actual arcade cabinet
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	tankbatt

Attached Files	tank_battalion_sounds.mp3 (883,760 bytes) Apr 4, 2009, 00:40
Attached Files	tankbatt.zip (437,742 bytes) Dec 26, 2012, 06:19 Uploaded by Mr. Do

No.04124 Tafoid Administrator Apr 2, 2009, 22:18	Linked Youtube vid to report via embedding. Confirmed. Acknowledged the documentation information.
No.04125 Fujix Administrator Apr 2, 2009, 22:20	Please write down the version number when you find the bug, don't use N/A. And always embed YouTube movie. Thanks.
No.04127 Tafoid Administrator Apr 2, 2009, 22:26	Sorry, Fujix - literally seconds earlier I embedded and fixed the bug as an acknowledged documentation report. If we are going with a sound bug, then we should confirm it.
No.04134 sxevious Tester Apr 3, 2009, 16:35	Theoretically the affected version should be 0.31 since the ding sound was never sampled and the tank rumbling sounds have always been off. Notice the comment in the TODO section of the driver source code.
No.04136 etabeta Developer Apr 3, 2009, 17:28	we usually put the current version when it's been reported (or the version it's been tested on) 0.31 in this case could be put in regression field (noticing it's been added back then)
No.04137 sxevious Tester Apr 4, 2009, 00:40	Uploaded mp3 of sounds from Tank Battalion. Sounds heard: coin ding, slow tank rumble, fast tank rumble, shot, explosion, extra life beeps.
No.04299 sxevious Tester May 1, 2009, 15:57	Correct addresses for sound and interrupt handling: 0c08 - coin sound 0c09 - extra life sound 0c0a - !rumble enable (0=enable) 0c0b - rumble select (0=slow,1=fast) 0c0c - shot sound 0c0d - explosion sound 0c0e - unused (never written) 0c0f - nmi enable (vblank generates nmi) 0c10 - irq ack (coin input generates irq) The "demo interrupt" stuff that is currently in the driver is completely wrong and should be removed. Having two enables for a single interrupt makes no sense, the correct nmi enable is at 0c0f. Writes to 0c0a control whether the tank rumble sound is heard or not but note this is inverted (0=on).
No.09161 Mr. Do Tester Dec 26, 2012, 06:19	Don't know if any of this helps, but... 1) I attached newer samples, recorded by Andy Welburn. Includes the credit sound. 2) Things I notice during gameplay: a) When player fires, fire.wav is triggered twice b) When enemy is hit by player fire, explosion.wav is triggered twice c) If you sit and do nothing, you can hear both those samples playing "randomly." As all the other timings seem off, that's probably affecting the engine sound, too?
No.14145 Osso Moderator Aug 30, 2017, 09:36	AJR did some work on this driver in the 0.189 dev cycle. At least the fire sound problem should be fixed.
No.14149 Fortuna Tester Aug 31, 2017, 06:24	Well, missing too the extra life sound, is a beep similar to the credit beep
No.17863 M.A.S.H. Senior Tester Aug 2, 2020, 21:46	Ryan Holtz added netlist audio to Tank Battalion. See https://git.redump.net/mame/commit/?id=48be14bade6c757d4a98400ee6016b5719bffd2a I tested the new netlist sound and it sounds very good.