03293: all twinkle.c sets: [debug] Memory leaks

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
03293	Misc.	Minor	Always	Jul 1, 2009, 11:59	Jul 23, 2010, 01:34

Tester	Firewave	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	Fixed	OS
Status [?]	Resolved			Driver	konami/twinkle.cpp
Version	0.132u2	Fixed in Version	0.136u1	Build	Debug
		Fixed in Git Commit		Github Pull Request #

Summary	03293: all twinkle.c sets: [debug] Memory leaks
Description	allocation #006986, 9792 bytes (src/lib/util/cdrom.c:165) allocation #006985, 3188 bytes (src/lib/util/cdrom.c:117) allocation #006963, 64 bytes (src/emu/machine/scsi.c:108)
Steps To Reproduce
Additional Information
Github Commit

Flags	Debug build specific
Regression Version	0.131u3 (Added)
Affected Sets / Systems	all twinkle.c sets

Attached Files

No.06420 trap15 Senior Tester Jul 23, 2010, 01:34 edited on: Jul 23, 2010, 01:40	Judging by where those allocations in your report are, I'd say this isn't just twinkle.c, but any game using SCSI or CD-ROMs? After further examination, the CD leaks shouldn't be there; cdrom.c has a close function that would free the memory. It's possible the twinkle.c driver doesn't call this. However, the SCSI appears to not have any sort of free function. I'd presume anything that uses the SCSI would just free it by itself, and the twinkle.c driver doesn't.

No.06420

trap15

Senior Tester

Jul 23, 2010, 01:34

edited on: Jul 23, 2010, 01:40

Judging by where those allocations in your report are, I'd say this isn't just twinkle.c, but any game using SCSI or CD-ROMs?
After further examination, the CD leaks shouldn't be there; cdrom.c has a close function that would free the memory. It's possible the twinkle.c driver doesn't call this.
However, the SCSI appears to not have any sort of free function. I'd presume anything that uses the SCSI would just free it by itself, and the twinkle.c driver doesn't.