Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
03727 Misc. Critical (emulation) Always Feb 11, 2010, 09:15 Feb 15, 2010, 18:59
Tester M.A.S.H. View Status Public Platform MAME (Self-compiled)
Assigned To M.A.S.H. Resolution Fixed OS Windows XP (32-bit)
Status [?] Resolved Driver spiders.cpp
Version 0.136u2 Fixed in Version 0.136u4 Build Normal
Summary 03727: spiders: Source typo in discrete sound system
Description The discrete sound system was changed in MAME 0.134u1. All Enable input were
be removed from a number of discrete sound modules.
The game Spiders (1981) has since this version a bad fire sound output. I compare
the MAME 0.134 and 0.134u1 sources and found in the discrete sound files that
all _ENABLE modules was removed like:

#define DST_LOOKUP_TABLE__ENABLE DISCRETE_INPUT(0)
#define DST_LOOKUP_TABLE__IN DISCRETE_INPUT(1)
#define DST_LOOKUP_TABLE__SIZE DISCRETE_INPUT(2)

to

#define DST_LOOKUP_TABLE__IN DISCRETE_INPUT(0)
#define DST_LOOKUP_TABLE__SIZE DISCRETE_INPUT(1)

and the INPUT files were renumbered. But not in sound\disc_mth.c.
So if you changed in emu\sound\disc_mth.c lines 1624-1626 from

#define DST_ASWITCH__CTRL DISCRETE_INPUT(1)
#define DST_ASWITCH__IN DISCRETE_INPUT(2)
#define DST_ASWITCH__THRESHOLD DISCRETE_INPUT(3)

to

#define DST_ASWITCH__CTRL DISCRETE_INPUT(0)
#define DST_ASWITCH__IN DISCRETE_INPUT(1)
#define DST_ASWITCH__THRESHOLD DISCRETE_INPUT(2)


the fire sound in Spiders sound like the old one in MAME 0.134 again.
Steps To Reproduce
Additional Information
Flags
Regression Version 0.134u1
Affected Sets / Systems spiders
Attached Files
 
Relationships
There are no relationship linked to this issue.
Notes
1
User avatar
No.05709
Tafoid
Administrator
Feb 11, 2010, 23:48
Well, here is the thing. That game had an implementation which was believed correct in 0.134. Things were changed in 0.134u1 and it was flagged, known to be inaccurate (not 100%) sound. Unless we can get some original pcb recordings, there isn't a lot I can do there. Reverting sometimes is the way to fix things, but often not.

I'll acknowledge with the hope some pcb audio shows up.