Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
04131 Debugger Major Always Dec 9, 2010, 11:09 Dec 12, 2010, 13:01
Tester Robbbert View Status Public Platform MAME (Unofficial Binary)
Assigned To Robbbert Resolution Fixed OS Windows XP (32-bit)
Status [?] Resolved Driver
Version 0.140u1 Fixed in Version 0.140u3 Build Normal
Fixed in Git Commit Github Pull Request #
Summary 04131: Debugger symlist command crashes MAME
Description Start the debugger with any Z80-based game.

Enter symlist.

It crashes to the command line.

Sorry my build is not a debug build so I don't have a trace for you.

If you are not able to reproduce then I will try to get one.
Steps To Reproduce see above
Additional Information
Github Commit
Flags
Regression Version 0.140u1
Affected Sets / Systems
Attached Files
 
Relationships
There are no relationship linked to this issue.
Notes
2
User avatar
No.06899
ShimaPong
Tester
Dec 9, 2010, 14:13
I have already reported this problem in Mame forums.
http://www.mameworld.info/ubbthreads/showthreaded.php?Cat=&Number=239721&page=&view=&sb=5&o=&fpart=1&vc=1

Try to change a code in tagmap.c I reported then please report your result.
User avatar
No.06908
Robbbert
Senior Tester
Dec 12, 2010, 09:47
Finally got time to look at this again....

I had noticed that symlist with no parameters produced cpu info on other cpu but hadn't logged it. Had not seen Shimapong's thread at all.

Now, looked at shimapong thread and confirmed that his fault tracking seems correct to me. My fix is slightly different (I always spend a lot of time testing) but essentially is the same sort of fix.

The missing global list is fixed in MESS r9761.

The tagmap issue in tagmap.h leads to a buffer overflow if the string is less than 2 characters long. It's amazing it has worked all this time. I did a loop test; a length of 1 caused 6 iterations of the while loop using unallocated memory. Added a modification of shimapong's fix. Added to MESS in r9762.