04170: warpwarpr2: warpwarpr2 (Warp & Warp Rock-Ola set 2) should be removed

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
04170	Misc.	Minor	Always	Jan 5, 2011, 18:15	Jan 6, 2011, 01:47

Tester	sxevious	View Status	Public	Platform
Assigned To		Resolution	No change required	OS
Status [?]	Closed			Driver	namco/warpwarp.cpp
Version	0.141	Fixed in Version		Build
		Fixed in Git Commit		Github Pull Request #

Summary	04170: warpwarpr2: warpwarpr2 (Warp & Warp Rock-Ola set 2) should be removed
Description	warpwarpr2 (Warp & Warp Rock-Ola set 2) should be removed: of the 5 roms in the zip, 4 are identical to those in warpwarpr1 and the other (g-09612.1t) only differs in message text and the checksum byte: warpwarpr1 says "1981 ROCK-OLA MFG. CORP." warpwarpr2 says "1981 ROCK-OLA MFG. CO." C:\WINDOWS\Temp>fc/b G-09613.1T g-09612.1t Comparing files G-09613.1T and G-09612.1T 00000400: 19 18 00000401: 1B 0C 00000402: 18 29 00000403: 0C 10 00000404: 29 0F 00000405: 10 16 00000406: 0F 00 00000407: 16 0A 00000408: 00 15 00000409: 0A 18 0000040A: 15 C1 0000040B: 18 14 0000040C: C1 0C 0000040D: 14 18 0000040E: 0C 1B 0000040F: 18 00 00000410: 1B 01 00000411: 00 08 00000412: 01 09 00000413: 08 01 00000414: 09 00 00000415: 01 E7 00000417: E7 00 000007FF: E7 1B Read the text from the bottom up, you can see '1981' followed by a space (00h) and the letters (1Bh = 'R', 18h = 'O', 0Ch = 'C', 14h = 'K', etc). This is a trivial difference which only affects the title screen. Instead of blindly dumping every version of a game someone should try and find out what the actual differences between sets are, particularly for something that claims to be a documentation project.
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	warpwarpr2

Attached Files

No.07012 Tafoid Administrator Jan 5, 2011, 19:19 edited on: Jan 5, 2011, 19:43	Closing. This information is already noted in the current source (warpwarp.c) already (differences in the two sets). While info like this is important, it's best submitted as source code adjustments (in .diff form) from the latest version. If you have more evidence of bug fixes, changes or omissions of code between different MAME sets based on a code analysis, feel free to submit the documentation as a (in .diff form) with your observations. The only way things like this can be documented is being put in as text in the source code. Regarding for your commentary on what MAME should and shouldn't qualify as a "set" - size in not important. It's documentation, all the same. This is also not the place to discuss such beliefs on how MAME is doing something correctly or incorrectly in how it deals with incoming data. If you must, there are other forums which other developers often frequent who would be more than happy to field your questions and assertions - just leave it out of this system, please.
No.07014 Haze Senior Tester Jan 6, 2011, 01:47	This isn't criteria for removing a set. It's entirely possible these are both legitimate revisions, and with the current support rules, it wouldn't even really matter if one was a bootleg, it came from a legitimate old PCB, that's good enough. Please stop trying to dictate MAME policy, you are not MameDev.

No.07012

Tafoid

Administrator

Jan 5, 2011, 19:19

edited on: Jan 5, 2011, 19:43

Closing.

This information is already noted in the current source (warpwarp.c) already (differences in the two sets).

While info like this is important, it's best submitted as source code adjustments (in .diff form) from the latest version. If you have more evidence of bug fixes, changes or omissions of code between different MAME sets based on a code analysis, feel free to submit the documentation as a (in .diff form) with your observations. The only way things like this can be documented is being put in as text in the source code.

Regarding for your commentary on what MAME should and shouldn't qualify as a "set" - size in not important. It's documentation, all the same. This is also not the place to discuss such beliefs on how MAME is doing something correctly or incorrectly in how it deals with incoming data. If you must, there are other forums which other developers often frequent who would be more than happy to field your questions and assertions - just leave it out of this system, please.

No.07014

Haze

Senior Tester

Jan 6, 2011, 01:47

This isn't criteria for removing a set.

It's entirely possible these are both legitimate revisions, and with the current support rules, it wouldn't even really matter if one was a bootleg, it came from a legitimate old PCB, that's good enough.

Please stop trying to dictate MAME policy, you are not MameDev.