04949: gameboy, gbcolor: [zeldalnk] Music off-key

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
04949	Sound	Minor	Always	Jul 15, 2012, 22:01	Aug 5, 2020, 04:29

Tester	Justin Kerk	View Status	Public	Platform
Assigned To	wilbert	Resolution	Fixed	OS
Status [?]	Resolved			Driver	nintendo/gb.cpp
Version	0.146u3	Fixed in Version	0.179	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	04949: gameboy, gbcolor: [zeldalnk] Music off-key
Description	(bug 289 from the old Bugzilla) The music in Zelda: Link's Awakening (zeldalnk on the softlist) is off-key, particularly noticeable on the higher notes.
Steps To Reproduce	1. download xml cheat file attached below and place in CHEAT folder 2. mess gameboy zeldalnk -cheat 3. progress to Player Select/Create Screen 4. select cheat in menu, using left/right arrow move to 6, then press ENTER to start music. 5. compare against the attached recording from the game cartridge on a real GBC
Additional Information	Also affects e.g. the low-health beep sound effect in the game. Not a regression, has always been like this.
Github Commit

Flags	Verified with Original
Regression Version
Affected Sets / Systems	gameboy, gbcolor

Attached Files	01- zelda6loud.mp3 (931,883 bytes) Jul 15, 2012, 22:02 Uploaded by Justin Kerk Recording of track 6 on a real GBC
	zelda4_healthbeep_comparison.mp3 (88,541 bytes) Jul 15, 2012, 22:04 Uploaded by Justin Kerk Low-health beep comparison: real GBC, then bgb emulator, then MESS
	zeldalnk.zip (325 bytes) Jul 15, 2012, 23:28 Uploaded by Tafoid Cheat file for "zeldalnk" softlist which allows for Sound Test

No.08803 Haze Senior Tester Jul 15, 2012, 22:24	I don't think you can call a ROM with just the music 'PD'.. The music is still (c) Nintendo.
No.08804 Tafoid Administrator Jul 15, 2012, 23:27	Yeah, we don't need attach roms to download, 'legal' or not. We can use a softlist title in this case, [b]zeldalnk[/b], with the following cheat code for a sound test I just made. I've attached this .xml cheat which you can place in your CHEAT folder and it should appear if you run the named set above. Just select 6 and press ENTER and you can hear it.
No.08805 Tafoid Administrator Jul 15, 2012, 23:34	This is similar to the way wswan, wscolor has it's sound.. it's high tones are way off at times.. Yet, that driver is flagged for imperfect sound. I wonder why gameboy and clones were give the green light when it's known to be bad in such instances?
No.12263 kazblox Tester Dec 17, 2015, 22:22	1. The sound core doesn't support the Color Gameboy's waves 2. The sound core is OLD MESS code from GNUBoy and other sound emulators around 1999/2000. Sampling issues off the wazoo, waveform issues, and many other problems. Please keep in mind that a rewrite; specifically one from gbemulator would fix this issue
No.17868 Justin Kerk Developer Aug 5, 2020, 03:19 edited on: Aug 5, 2020, 03:20	This was fixed in 0.179, presumably by judge's rewrite of the Game Boy sound core in c3e0ead53494abe36105587fd485e317a788ec5e.
No.17869 Tafoid Administrator Aug 5, 2020, 04:29	There are other issues with gameboy sound that I guess I need to report. I'll work on getting examples of games which regressed in sound using gameboy sound (including GBA titles).