Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
05052 Color/Palette Minor Always Oct 31, 2012, 13:41 Aug 13, 2022, 11:37
Tester trebor View Status Public Platform MAME (Unofficial Binary)
Assigned To Resolution Open OS
Status [?] Confirmed Driver
Version 0.147u1 Fixed in Version Build 64-bit
Fixed in Git Commit Github Pull Request #
Summary 05052: dkong dkongo: Switching to TKG-02 (Radarscope Conversion) is no longer creating the proper color palette
Description Starting with MAME 0.147u1 Donkey Kong's color palette is not updating properly when switching Video Hardware --> TKG-04 to TKG-02. A blue 'film' is seen across the screen; palette colors not correct.
Steps To Reproduce -Select dkong ROM.
-Press 'Tab' to bring up internal menu.
-Scroll down to "Driver Configuration" [Newer versions of MAME list this as "Machine Configuration"].
-Press 'Enter'.
-Use arrows keys to switch "Video Hardware" from "TKG-04 (Two board set)" to
"TKG-02 (Radarscope Conversion)".
Additional Information Out of 130,000+ Donkey Kong cabinets sold [ ], at best only a couple thousand were Radarscope hardware conversions. A rare version that hopefully can be preserved and represented properly under MAME, once again.
Github Commit
Regression Version 0.147u1
Affected Sets / Systems dkong dkongo
Attached Files
png file icon DK_TKG-02_Comp.png (17,498 bytes) Aug 13, 2016, 01:38 Uploaded by trebor
TKG-02 working properly under 0.147 and broke under 0.147u1
There are no relationship linked to this issue.
User avatar
Aug 12, 2016, 18:32
MAME 0.147 also has the proper behavior of the switch in place.
This narrows down the break from between MAME 0.147 on Sept 17, 2012 to MAME 0.147u2 on Oct 30, 2012.
User avatar
Aug 12, 2016, 20:49
Narrowing it down even further, the breakage is evident under MAME 0.147u1 as well.

MAME 0.147 = September 17, 2012 = Palette switch works fine - TKG-02 Colors correct.
MAME 0.147u1 = October 8, 2012 = Palette switch is broken - TKG-02 Blue film on screen instead.
User avatar
Aug 13, 2016, 01:12
Here are the list of updates that impacted dkong between MAME 0.147 and MAME 0.147u1:

Monday 17th September, 2012
Memory handler normalization, part 1.
READ/WRITE_DEVICE*_HANDLERs are now passed an
address_space &, and the 8-bit variants get a mem_mask
as well. This means they are now directly compatible
with the member function delegates. Added a generic
address space to the driver_device that can be used
when no specific address space is available. Also
declare device callbacks with default mem_mask
Memory handler normalization, part 2. Change legacy
read/write handlers to take an address_space & instead
of an address_space *. Also update pretty much all other
functions to take a reference where appropriate.
Memory handler cleanup 3. Add mem_mask parameter
to 8-bit handlers to match the others. To ease
pain, added DECLARE_READ/WRITE_HANDLER macros that
set up a default parameter. Also updated devcb so
that the handlers can be called with or without the
Modernized screen update calls (no whatsnew)

Tuesday 18th September, 2012
manual cleanup of mame and mess includes (no whatsnew)
changed most of screen.machine() to machine() (no whatsnew)

Wednesday 19th September, 2012
Removed device_memory_interface from driver_device, fixes issues with dkong clones, and various others, require clean compile (no whatsnew)
dkong fix (no whatsnew)
Since nobody checks for NULLs anyway, make
device_memory_interface::space() assert against NULL and
return a reference, and pushed references throughout all
address space usage in the system. Added a has_space()
method to check for those rare case when it is ambiguous.

Also reinstated the generic space and added fatal error
handlers if anyone tries to actually read/write from it.

Sunday 23rd September, 2012
Fix for MT5018. [Couriersud]
Also improves blue background levels and gradient for Radar Scope.

Monday 24th September, 2012
Introducing TIMER_CALLBACK_MEMBER and modernization part 1 (no whatsnew)

Friday 28th September, 2012
Replace some *_DEVICE_HANDLER with _MEMBER calls, mostly audio (no whatsnew)

Tuesday 2nd October, 2012
typo (no, not a typo in the original games titlescreen, but indeed a typo in MAME)
fix dkong3 crash

Sunday 7th October, 2012
srcclean (nw)
User avatar
Aug 13, 2016, 01:22
Sunday 23rd September, 2012
Fix for MT5018. [Couriersud]
Also improves blue background levels and gradient for Radar Scope.

The above appears to be the strongest candidate for the regression as there are a couple of references to "DKONG_RADARSCP_CONVERSION".
User avatar
Mar 29, 2018, 16:18
Changing the blue radarscp_net_info from RES_NET_AMP_EMITTER to RES_NET_AMP_DARLINGTON on line 133 of video/dkong.cpp seems to improve the blue background level.
Perhaps the dkong conversion has the darlington pair for blue level.
User avatar
Mar 31, 2018, 14:06
Confirmed and *THANK YOU* tedgreen!

Tested under MAME 0.196, changing the blue radarscp_net_info from RES_NET_AMP_EMITTER to RES_NET_AMP_DARLINGTON on line 133 of video/dkong.cpp, fixes the problem.
User avatar
Senior Tester
Jan 15, 2019, 16:21
It seems the provided solution was never integrated into official mame.
User avatar
Aug 13, 2022, 11:37
Solution still not integrated as of MAME 0.246; just the file location and name are slightly different now under more recent versions:

Change the blue radarscp_net_info from RES_NET_AMP_EMITTER to RES_NET_AMP_DARLINGTON on line 133 of \src\mame\nintendo\dkong_v.cpp

The above (still) fixes the problem.