| ID | Category [?] | Severity [?] | Reproducibility | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 05091 | Color/Palette | Minor | Always | Dec 24, 2012, 17:38 | Dec 24, 2012, 23:54 |
| Tester | M.A.S.H. | View Status | Public | Platform | MAME (Self-compiled) |
| Assigned To | M.A.S.H. | Resolution | Fixed | OS | Windows XP |
| Status [?] | Resolved | Driver | |||
| Version | 0.147u4 | Fixed in Version | 0.148 | Build | Normal |
| Fixed in Git Commit | Github Pull Request # | ||||
| Summary | 05091: crater: Wrong colors | ||||
| Description |
The colors in Crater Raider are wrong since MAME 0.36b6. See Youtube video: |
||||
| Steps To Reproduce |
In MAME 0.33b7 Aaron Giles fixed the colors/gfxdecode for Crater Raider, by adding an extra crater_gfxdecode: The spyhunt_gfxdecode (drivers\mcr3.c) was changed from static struct GfxDecodeInfo spyhunt_gfxdecodeinfo[] = { { 1, 0x0000, &spyhunt_charlayout_128, 0, 4 }, /* top half */ { 1, 0x0004, &spyhunt_charlayout_128, 0, 4 }, /* bottom half */ { 1, 0x8000, &mcr3_spritelayout_256, 0, 4 }, { 1, 0x28000, &spyhunt_alphalayout, 8*16, 4 }, { -1 } /* end of array */ }; to static struct GfxDecodeInfo spyhunt_gfxdecodeinfo[] = { { 1, 0x0000, &spyhunt_charlayout_128, 1*16, 1 }, /* top half */ { 1, 0x0004, &spyhunt_charlayout_128, 1*16, 1 }, /* bottom half */ { 1, 0x8000, &mcr3_spritelayout_256, 0*16, 1 }, { 1, 0x28000, &spyhunt_alphalayout, 8*16, 1 }, { -1 } /* end of array */ }; and the extra crater_gfxdecode was added: static struct GfxDecodeInfo crater_gfxdecodeinfo[] = { { 1, 0x0000, &spyhunt_charlayout_128, 3*16, 1 }, /* top half */ { 1, 0x0004, &spyhunt_charlayout_128, 3*16, 1 }, /* bottom half */ { 1, 0x8000, &mcr3_spritelayout_256, 0*16, 1 }, { 1, 0x28000, &spyhunt_alphalayout, 8*16, 1 }, { -1 } /* end of array */ }; In MAME 0.36b6 the MC3 driver was updated and the crater_gfxdecode was *mistakenly* removed. The spyhunt_gfxdecode was changed from static struct GfxDecodeInfo spyhunt_gfxdecodeinfo[] = { { 1, 0x0000, &spyhunt_charlayout_128, 1*16, 1 }, /* top half */ { 1, 0x0004, &spyhunt_charlayout_128, 1*16, 1 }, /* bottom half */ { 1, 0x8000, &mcr3_spritelayout_256, 0*16, 1 }, { 1, 0x28000, &spyhunt_alphalayout, 8*16, 1 }, { -1 } /* end of array */ }; to static struct GfxDecodeInfo spyhunt_gfxdecodeinfo[] = { { 1, 0x00000, &spyhunt_charlayout, 1*16, 1 }, { 1, 0x08000, &spritelayout, 0*16, 4 }, { 1, 0x48000, &spyhunt_alphalayout, 8*16, 1 }, { -1 } /* end of array */ }; and Crater Raider uses from now on the spyhunt_gfxdecode. Now in MAME 0.147u4 the spyhunt_gfxdecode looks like this: static GFXDECODE_START( spyhunt ) GFXDECODE_ENTRY( "gfx1", 0, spyhunt_charlayout, 1*16, 1 ) GFXDECODE_ENTRY( "gfx2", 0, mcr_sprite_layout, 0*16, 4 ) GFXDECODE_ENTRY( "gfx3", 0, spyhunt_alphalayout, 4*16, 1 ) GFXDECODE_END and if we look at the old crater_gfxdecode in MAME 0.33b7 we must only changed 'spyhunt_charlayout' from 1*16 to 3*16: static GFXDECODE_START( spyhunt ) GFXDECODE_ENTRY( "gfx1", 0, spyhunt_charlayout, 3*16, 1 ) GFXDECODE_ENTRY( "gfx2", 0, mcr_sprite_layout, 0*16, 4 ) GFXDECODE_ENTRY( "gfx3", 0, spyhunt_alphalayout, 4*16, 1 ) GFXDECODE_END This fixed the colors in Crater Raider and the Spy Hunter colors are no affected! (see crater 0147u4 before & after.png) |
||||
| Additional Information | |||||
| Github Commit | |||||
| Flags | |||||
| Regression Version | 0.36b6 | ||||
| Affected Sets / Systems | crater | ||||
|
Attached Files
|
 crater 0147u4 before & after.png (31,986 bytes) Dec 24, 2012, 17:38 Uploaded by M.A.S.H. | ||||