05152: all gameboy.c sets: Crashes on exit when no cart was successfully loaded

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
05152	Interface	Critical (emulator)	Always	Feb 12, 2013, 08:12	Feb 15, 2013, 06:36

Tester	Robbbert	View Status	Public	Platform	MESS (Self-compiled)
Assigned To	Firewave	Resolution	Fixed	OS
Status [?]	Resolved			Driver	nintendo/gb.cpp
Version	0.148u1	Fixed in Version	0.148u2	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	05152: all gameboy.c sets: Crashes on exit when no cart was successfully loaded
Description	Start any of these systems with a cart preloaded. Cart is not seen by the system, just get black rectangle on screen. Then exit, and it crashes. Didn't try via software list; cart is from old way.
Steps To Reproduce
Additional Information	was working a week earlier
Github Commit

Flags
Regression Version
Affected Sets / Systems	all gameboy.c sets

Attached Files

No.09365 wilbert Developer Feb 13, 2013, 20:47	Unable to reproduce. Started the gameboy driver with a cart mounted and it booted fine.
No.09374 Tafoid Administrator Feb 14, 2013, 12:04	I can "mess gameboy kirby", for example, when use the file manager to load another cart either picker or software list and I get a crash. Sound more like a multisession issue?
No.09379 Firewave Senior Tester Feb 14, 2013, 19:39	No crashes for me and I can also change carts in the File Manager without any issues.
No.09380 Firewave Senior Tester Feb 14, 2013, 19:54	I think your issue might be an invalid cart, that is being mounted, but not run. In that case there will be a crash on exit because of a NULL pointer. ----------------------------------------------------- Exception at EIP=000000014058AA86 (+0x4058aa86): ACCESS VIOLATION While attempting to read memory at 0000000000000000 ----------------------------------------------------- RAX=0000000000000000 RBX=0000000000000000 RCX=0000000000000000 RDX=0000000142AE6B40 RSI=0000000000000000 RDI=00000000002C66A0 RBP=0000000000000000 RSP=00000000002C6670 R8=0000000142DB8128 R9=6875646355403E2D R10=FEFEFEFEFEFEFEFF R11=8080808080808080 R12=0000000000000000 R13=0000000000000000 R14=0000000000000000 R15=0000000000000000 ----------------------------------------------------- Stack crawl: 00000000002C66A0: 000000014058AA86 (base_gb_cart_slot_device::call_unload+0x0036, s:\svn\mame\src\mess\machine\gb_slot.c:418) 00000000002C66D0: 0000000141870121 (device_image_interface::unload+0x0051, s:\svn\mame\src\emu\diimage.c:1166) 00000000002C6740: 0000000141AB7EF7 (image_unload_all+0x0077, s:\svn\mame\src\emu\image.c:197) 00000000002C6770: 0000000140A1991E (delegate_base<void,_noparam,_noparam,_noparam,_noparam,_noparam>::operator()+0x002e, s:\svn\mame\src\emu\delegate.h:539) 00000000002C67B0: 000000014188123F (running_machine::call_notifiers+0x006f, s:\svn\mame\src\emu\machine.c:735) 00000000002C6D20: 0000000141880E4A (running_machine::run+0x041a, s:\svn\mame\src\emu\machine.c:448) 00000000002CD4A0: 00000001416F48F8 (mame_execute+0x01f8, s:\svn\mame\src\emu\mame.c:190) 00000000002CF3C0: 000000014183316F (cli_frontend::execute+0x0a2f, s:\svn\mame\src\emu\clifront.c:258) 00000000002CF8B0: 0000000141E556BB (utf8_main+0x017b, s:\svn\mame\src\osd\windows\winmain.c:493) 00000000002CF8F0: 0000000141E512F0 (wmain+0x00b0, s:\svn\mame\src\osd\windows\main.c:82) 00000000002CF940: 0000000141DF089C (__tmainCRTStartup+0x00ec, f:\dd\vctools\crt_bld\self_64_amd64\crt\src\crt0.c:241) 00000000002CF970: 0000000141DF09DE (wmainCRTStartup+0x000e, f:\dd\vctools\crt_bld\self_64_amd64\crt\src\crt0.c:164) 00000000002CF9A0: 0000000076CE652D (BaseThreadInitThunk+0x000d) 00000000002CF9F0: 000000007728C521 (RtlUserThreadStart+0x0021) I committed a fix for that in r21074.
No.09382 Robbbert Senior Tester Feb 15, 2013, 06:36 edited on: Feb 15, 2013, 06:38	The cart was a valid one a week ago, but now it is invalid? How can that be? The crash on exit is fixed, but the original issue of cart no longer recognised is still there.