- --
Viewing Issue Advanced Details
ID | Category [?] | Severity [?] | Reproducibility | Date Submitted | Last Update |
---|---|---|---|---|---|
05281 | Color/Palette | Minor | Always | Sep 5, 2013, 00:40 | Sep 8, 2013, 17:03 |
Tester | M.A.S.H. | View Status | Public | Platform | MAME (Self-compiled) |
Assigned To | hap | Resolution | Fixed | OS | Windows XP |
Status [?] | Resolved | Driver | |||
Version | 0.149u1 | Fixed in Version | 0.150 | Build | Normal |
Fixed in Git Commit | Github Pull Request # | ||||
Summary | 05281: rollingc: Wrong colors | ||||
Description |
The colors in Rolling Crash / Moon Base are possible wrong by comparing them with the Arcade Flyer at: http://flyers.arcade-museum.com/?page=flyer&db=videodb&id=6301&image=1 I have added a new get_pens to the video driver for rollingc and the colors looks correct now! See snapshot to compare the colors of the Arcade Flyer with the new ones and the old ones at the button. Use diff file to test it! |
||||
Steps To Reproduce | |||||
Additional Information | |||||
Github Commit | |||||
Flags | |||||
Regression Version | |||||
Affected Sets / Systems | rollingc | ||||
Attached Files
|
ArcadeFlyer-MAME-new_&_old_colors.png (296,689 bytes) Sep 5, 2013, 00:40 Uploaded by M.A.S.H.
| ||||
rollingc.diff (1,469 bytes) Sep 5, 2013, 00:41 Uploaded by M.A.S.H. [Show Content] [Hide Content]diff -Nru src-old/mame/includes/8080bw.h src/mame/includes/8080bw.h --- src-old/mame/includes/8080bw.h 2013-07-23 09:35:14.000000000 +0100 +++ src/mame/includes/8080bw.h 2013-09-05 02:30:26.000000000 +0100 @@ -141,6 +141,7 @@ void invadpt2_get_pens( pen_t *pens ); void sflush_get_pens( pen_t *pens ); void cosmo_get_pens( pen_t *pens ); + void rollingc_get_pens( pen_t *pens ); inline void set_pixel( bitmap_rgb32 &bitmap, UINT8 y, UINT8 x, pen_t *pens, UINT8 color ); inline void set_8_pixels( bitmap_rgb32 &bitmap, UINT8 y, UINT8 x, UINT8 data, pen_t *pens, UINT8 fore_color, UINT8 back_color ); void clear_extra_columns( bitmap_rgb32 &bitmap, pen_t *pens, UINT8 color ); diff -Nru src-old/mame/video/8080bw.c src/mame/video/8080bw.c --- src-old/mame/video/8080bw.c 2013-02-13 16:41:04.000000000 +0100 +++ src/mame/video/8080bw.c 2013-09-05 02:31:34.000000000 +0100 @@ -61,6 +61,17 @@ } +void _8080bw_state::rollingc_get_pens( pen_t *pens ) +{ + offs_t i; + + for (i = 0; i < NUM_PENS; i++) + { + pens[i] = MAKE_RGB(pal1bit(i >> 2), pal1bit(i >> 1), pal1bit(i >> 0)); + } +} + + inline void _8080bw_state::set_pixel( bitmap_rgb32 &bitmap, UINT8 y, UINT8 x, pen_t *pens, UINT8 color ) { if (y >= MW8080BW_VCOUNTER_START_NO_VBLANK) @@ -240,7 +251,7 @@ pen_t pens[NUM_PENS]; offs_t offs; - invadpt2_get_pens(pens); + rollingc_get_pens(pens); for (offs = 0; offs < m_main_ram.bytes(); offs++) { | |||||
ebay-rollingc.jpg (907,494 bytes) Sep 6, 2013, 15:43 Uploaded by M.A.S.H. | |||||
Relationships
There are no relationship linked to this issue. |
Notes
4
No.09772
hap Developer
Sep 5, 2013, 10:30
edited on: Sep 5, 2013, 16:57 |
ok *edit* flyer suggests the colors differ even more, and even background color. I'll see what I can do, and if i can't figure it out we'll at least have improved colors with your patch. |
---|---|
No.09779
M.A.S.H. Senior Tester
Sep 6, 2013, 15:43
edited on: Sep 6, 2013, 15:50 |
Found ROLLING CRASH Cocktail at eBay: http://www.ebay.co.uk/itm/Vintage-NICHIBUTSU-ROLLING-CRASH-Cocktail-Cabinet-Arcade-Machine-WORKING-Retro-/321195359002?pt=UK_Video_Games_Coin_Operated_MJ&hash=item4ac8bc3b1a&ssPageName=RSS:B:SHOP:GB:101 Upload sceenhots here :) |
No.09780
hap Developer
Sep 6, 2013, 16:35
|
hmm: orange, darkblue, darkgreen are not in 3bpp. We may be missing a color PROM here then :( |
No.09783
Stiletto Developer
Sep 7, 2013, 16:23
|
I dunno MASH, I don't think the invaders look at all similar in your screenshot. |