Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
05379 DIP/Input Minor Always Nov 25, 2013, 10:45 Jan 19, 2021, 18:31
Tester Yonah View Status Public Platform MAME (Official Binary)
Assigned To Osso Resolution Fixed OS Windows Vista/7/8 (64-bit)
Status [?] Resolved Driver xybots.cpp
Version 0.151 Fixed in Version 0.228 Build 64-bit
Fixed in Git Commit Github Pull Request #
Summary 05379: xybots: Coin inputs are backwards.
Description Coin 1 adds a credit to Player 2 (right side/green) and Coin 2 adds a credit to Player 1 (left side/blue)
Steps To Reproduce
Additional Information
Github Commit
Flags
Regression Version 0.149u1
Affected Sets / Systems xybots
Attached Files
 
Relationships
There are no relationship linked to this issue.
Notes
3
User avatar
No.10011
Tafoid
Administrator
Nov 25, 2013, 14:40
r24252 comments the functionality - xybots uses a swapped version of the normal handler.
User avatar
No.10014
Fujix
Administrator
Nov 26, 2013, 05:46
Thank you, changed the status.
User avatar
No.18395
Tafoid
Administrator
Jan 19, 2021, 05:26
As I commented, the source indicated a "swapped" version of the handler (JSA1). Ii used to be simply port modified to give expected behavior but when work was done in the 0.149u1 development cycle, the change was commented as a TODO and never readdressed - giving us the unexpected behavior.

https://github.com/mamedev/mame/commit/5d93590f309024380e8c5f45c9a009bf15b1285d

The comments in the atarijsa.cpp at the top of the file fails to even mention xybots as using JSA1.
At the very least, until more can be done, I'd suggest taking from comment the code to swap the coin inputs for logical use.