05480: thndrx2: Sound doesn't play correctly

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
05480	Sound	Minor	Always	Mar 21, 2014, 21:53	Mar 24, 2014, 17:25

Tester	josejl1987	View Status	Public	Platform	MAME (Official Binary)
Assigned To		Resolution	No change required	OS	Windows Vista/7/8 (64-bit)
Status [?]	Closed			Driver	konami/tmnt.cpp
Version	0.152	Fixed in Version		Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	05480: thndrx2: Sound doesn't play correctly
Description	The YM2151 only sounds on the left channel,although the PCM samples play correctly on both channels. Edit 1: I just noticed something in mono mode. During the screen test,the insert coin effect sounds on both left and right,but when the title screen appears,it only sounds on the left.I uploaded a sound recording of that.
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	thndrx2

Attached Files	thndrx2.ogg (694,723 bytes) Mar 24, 2014, 16:53 Uploaded by josejl1987 Sound recording

No.10498 Tafoid Administrator Mar 21, 2014, 23:44	You must enter the Service Mode (F2) - (7) Coin-Game Options, (8) Sound Output - and change to Stereo. The game/board by default chooses mono for the sound effects. I honestly don't think this is a bug.
No.10499 josejl1987 Tester Mar 22, 2014, 00:12 edited on: Mar 22, 2014, 00:43	You are right,setting it in stereo makes it play correctly,I missed that option. However,even if it is mono,shouldn't it sound in both channels? Just like the K053260 output sounds on both channels. I also checked tmnt2,which also has the mono/stereo option in the service menu.That one has YM2151 output on both left and right channels in mono mode.
No.10500 M.A.S.H. Senior Tester Mar 22, 2014, 01:48	Some other tmnt.c games have the same sound problem. All games got default EEPROMs in MAME 0.137. They must be updated!
No.10501 Haze Senior Tester Mar 22, 2014, 23:10	No, they don't need to be updated. This isn't a bug, the 'correct' default for those games is mono.
No.10502 AWJ Developer Mar 23, 2014, 00:21	For hard dipswitches we do override the factory defaults in some cases (upright even if factory default is cocktail, demo sound on, allow continue, stereo if available, etc.) As long as we're providing default EEPROMs, maybe we should do the same with soft dipswitches?
No.10503 Haze Senior Tester Mar 23, 2014, 11:44	I'm not sure it would be worth the romset churn for something that isn't really a bug anyway. The default eeproms exist mainly to make reg tests easier (so games actually boot) and to provide suitable default calibrations etc. for use with MAME (because getting them right without the real devices attached can be a pain) At most changing it now would be a minor 'user convenience' feature, but I'd argue it would actually be less of a convenience due to the changing roms.
No.10504 NekoEd Senior Tester Mar 24, 2014, 01:23	Setting this as Direction Needed until we determine what we should do with this situation. Personally, I recommend leaving it as it is; if those are the default EEPROM settings, then that's how they should be left (mostly because changing them all now would indeed be a horrendous pain in the neck.)
No.10505 hap Developer Mar 24, 2014, 14:20	FWIW i agree with AWJ here, "As long as we're providing default EEPROMs", but! I think it'd even better if these Konami games (simple cases of 'hold-F2->press-F3') did not have 'canned' eeproms at all.
No.10506 Haze Senior Tester Mar 24, 2014, 16:04 edited on: Mar 24, 2014, 16:05	you clearly forget the sheer volume of posts asking the same questions everywhere / reporting the emulator as broken because they didn't understand the need to do that sequence.. since we added the defaults I haven't seen a single one. The last thing we need is people reporting MAME as completely broken due to user errors, so whatever we can do to minimize user errors and aid in regression testing is a good thing - there's a reason we've been far better at keeping MAME drivers in good shape than MESS ones!
No.10507 josejl1987 Tester Mar 24, 2014, 17:10	I don't know nearly as much as the developers,that's for sure,but in my humble opinion,I think that this isn't just a settings issue. Sure,in stereo mode it sounds fine,but having no sound at all in the right speaker from the YM2151 after the title screen,I don't know,it just seems a little strange.As far as I know,both speakers should get the same sound in mono mode.
No.10508 hap Developer Mar 24, 2014, 17:25	@Haze (nah i didnt forget) Yeah, i see your point. Our line of expected end-user capability to boot up MAME differs, eg. remember when i reverted your cps3 driver user-friendly feature and you nearly exploded?:P I'd only include preset eeprom in cases where the machine locks up or when calibration is very hard.