 No.12869
cuavas Administrator
Jul 1, 2016, 05:11
|
valgrind output: ==13595== Memcheck, a memory error detector ==13595== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al. ==13595== Using Valgrind-3.9.0 and LibVEX; rerun with -h for copyright info ==13595== Command: ./mametiny64 -language Italian ==13595== ==13595== Conditional jump or move depends on uninitialised value(s) ==13595== at 0x48F943: sdl_window_info::update_cursor_state() (window.cpp:244) ==13595== by 0x4905A8: sdl_window_info::update() (window.cpp:562) ==13595== by 0x48C22A: sdl_osd_interface::update(bool) (video.cpp:144) ==13595== by 0x963921: video_manager::frame_update(bool) (video.cpp:234) ==13595== by 0x58EA85: mame_ui_manager::set_startup_text(char const*, bool) (ui.cpp:365) ==13595== by 0x548B6A: mame_machine_manager::create_ui(running_machine&) (mame.cpp:277) ==13595== by 0x8F8D86: running_machine::start() (machine.cpp:214) ==13595== by 0x8F8FB4: running_machine::run(bool) (machine.cpp:301) ==13595== by 0x54AC60: mame_machine_manager::execute() (mame.cpp:226) ==13595== by 0x5B7788: cli_frontend::execute(int, char**) (clifront.cpp:282) ==13595== by 0x549E6C: emulator_info::start_frontend(emu_options&, osd_interface&, int, char**) (mame.cpp:325) ==13595== by 0x437465: main (sdlmain.cpp:214) ==13595== ==13595== Conditional jump or move depends on uninitialised value(s) ==13595== at 0x48F970: sdl_window_info::update_cursor_state() (window.cpp:225) ==13595== by 0x4905A8: sdl_window_info::update() (window.cpp:562) ==13595== by 0x48C22A: sdl_osd_interface::update(bool) (video.cpp:144) ==13595== by 0x963921: video_manager::frame_update(bool) (video.cpp:234) ==13595== by 0x58EA85: mame_ui_manager::set_startup_text(char const*, bool) (ui.cpp:365) ==13595== by 0x548B6A: mame_machine_manager::create_ui(running_machine&) (mame.cpp:277) ==13595== by 0x8F8D86: running_machine::start() (machine.cpp:214) ==13595== by 0x8F8FB4: running_machine::run(bool) (machine.cpp:301) ==13595== by 0x54AC60: mame_machine_manager::execute() (mame.cpp:226) ==13595== by 0x5B7788: cli_frontend::execute(int, char**) (clifront.cpp:282) ==13595== by 0x549E6C: emulator_info::start_frontend(emu_options&, osd_interface&, int, char**) (mame.cpp:325) ==13595== by 0x437465: main (sdlmain.cpp:214) ==13595== ==13595== Conditional jump or move depends on uninitialised value(s) ==13595== at 0x5F910D: ui::menu::draw(unsigned int, float, float) (menu.cpp:700) ==13595== by 0x604439: ui::menu::process(unsigned int, float, float) (menu.cpp:401) ==13595== by 0x61004B: ui::menu_selector::handle() (selector.cpp:59) ==13595== by 0x60068A: ui::menu::ui_handler(render_container*, mame_ui_manager&) (menu.cpp:1236) ==13595== by 0x599922: std::_Function_handler<unsigned int (render_container*), void mame_ui_manager::set_handler<mame_ui_manager&>(ui_callback_type, unsigned int (*)(render_container*, mame_ui_manager&), unsigned int (render_container*, mame_ui_manager&))::{lambda(render_container*)#1}>::_M_invoke(std::_Any_data const&, render_container*&&) (ui.h:193) ==13595== by 0x591464: mame_ui_manager::update_and_render(render_container*) (functional:2271) ==13595== by 0x549EBE: emulator_info::draw_user_interface(running_machine&) (mame.cpp:330) ==13595== by 0x9638A7: video_manager::frame_update(bool) (video.cpp:225) ==13595== by 0x8F908B: running_machine::run(bool) (machine.cpp:346) ==13595== by 0x54AC60: mame_machine_manager::execute() (mame.cpp:226) ==13595== by 0x5B7788: cli_frontend::execute(int, char**) (clifront.cpp:282) ==13595== by 0x549E6C: emulator_info::start_frontend(emu_options&, osd_interface&, int, char**) (mame.cpp:325) ==13595== ==13595== Conditional jump or move depends on uninitialised value(s) ==13595== at 0x5F9118: ui::menu::draw(unsigned int, float, float) (menu.cpp:704) ==13595== by 0x604439: ui::menu::process(unsigned int, float, float) (menu.cpp:401) ==13595== by 0x61004B: ui::menu_selector::handle() (selector.cpp:59) ==13595== by 0x60068A: ui::menu::ui_handler(render_container*, mame_ui_manager&) (menu.cpp:1236) ==13595== by 0x599922: std::_Function_handler<unsigned int (render_container*), void mame_ui_manager::set_handler<mame_ui_manager&>(ui_callback_type, unsigned int (*)(render_container*, mame_ui_manager&), unsigned int (render_container*, mame_ui_manager&))::{lambda(render_container*)#1}>::_M_invoke(std::_Any_data const&, render_container*&&) (ui.h:193) ==13595== by 0x591464: mame_ui_manager::update_and_render(render_container*) (functional:2271) ==13595== by 0x549EBE: emulator_info::draw_user_interface(running_machine&) (mame.cpp:330) ==13595== by 0x9638A7: video_manager::frame_update(bool) (video.cpp:225) ==13595== by 0x8F908B: running_machine::run(bool) (machine.cpp:346) ==13595== by 0x54AC60: mame_machine_manager::execute() (mame.cpp:226) ==13595== by 0x5B7788: cli_frontend::execute(int, char**) (clifront.cpp:282) ==13595== by 0x549E6C: emulator_info::start_frontend(emu_options&, osd_interface&, int, char**) (mame.cpp:325) ==13595== ==13595== Use of uninitialised value of size 8 ==13595== at 0x4A092F2: strlen (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==13595== by 0x61BAF1: ui::text_layout::add_text(char const*, ui::text_layout::char_style const&) (text.cpp:115) ==13595== by 0x590388: mame_ui_manager::draw_text_full(render_container*, char const*, float, float, float, ui::text_layout::text_justify, ui::text_layout::word_wrapping, mame_ui_manager::draw_mode, rgb_t, rgb_t, float*, float*, float) (text.h:77) ==13595== by 0x5F9626: ui::menu::draw(unsigned int, float, float) (menu.cpp:725) ==13595== by 0x604439: ui::menu::process(unsigned int, float, float) (menu.cpp:401) ==13595== by 0x61004B: ui::menu_selector::handle() (selector.cpp:59) ==13595== by 0x60068A: ui::menu::ui_handler(render_container*, mame_ui_manager&) (menu.cpp:1236) ==13595== by 0x599922: std::_Function_handler<unsigned int (render_container*), void mame_ui_manager::set_handler<mame_ui_manager&>(ui_callback_type, unsigned int (*)(render_container*, mame_ui_manager&), unsigned int (render_container*, mame_ui_manager&))::{lambda(render_container*)#1}>::_M_invoke(std::_Any_data const&, render_container*&&) (ui.h:193) ==13595== by 0x591464: mame_ui_manager::update_and_render(render_container*) (functional:2271) ==13595== by 0x549EBE: emulator_info::draw_user_interface(running_machine&) (mame.cpp:330) ==13595== by 0x9638A7: video_manager::frame_update(bool) (video.cpp:225) ==13595== by 0x8F908B: running_machine::run(bool) (machine.cpp:346) ==13595== ==13595== Invalid read of size 1 ==13595== at 0x4A092F2: strlen (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==13595== by 0x61BAF1: ui::text_layout::add_text(char const*, ui::text_layout::char_style const&) (text.cpp:115) ==13595== by 0x590388: mame_ui_manager::draw_text_full(render_container*, char const*, float, float, float, ui::text_layout::text_justify, ui::text_layout::word_wrapping, mame_ui_manager::draw_mode, rgb_t, rgb_t, float*, float*, float) (text.h:77) ==13595== by 0x5F9626: ui::menu::draw(unsigned int, float, float) (menu.cpp:725) ==13595== by 0x604439: ui::menu::process(unsigned int, float, float) (menu.cpp:401) ==13595== by 0x61004B: ui::menu_selector::handle() (selector.cpp:59) ==13595== by 0x60068A: ui::menu::ui_handler(render_container*, mame_ui_manager&) (menu.cpp:1236) ==13595== by 0x599922: std::_Function_handler<unsigned int (render_container*), void mame_ui_manager::set_handler<mame_ui_manager&>(ui_callback_type, unsigned int (*)(render_container*, mame_ui_manager&), unsigned int (render_container*, mame_ui_manager&))::{lambda(render_container*)#1}>::_M_invoke(std::_Any_data const&, render_container*&&) (ui.h:193) ==13595== by 0x591464: mame_ui_manager::update_and_render(render_container*) (functional:2271) ==13595== by 0x549EBE: emulator_info::draw_user_interface(running_machine&) (mame.cpp:330) ==13595== by 0x9638A7: video_manager::frame_update(bool) (video.cpp:225) ==13595== by 0x8F908B: running_machine::run(bool) (machine.cpp:346) ==13595== Address 0xffffffff is not stack'd, malloc'd or (recently) free'd ==13595== ==13595== ==13595== Process terminating with default action of signal 11 (SIGSEGV) ==13595== Access not within mapped region at address 0xFFFFFFFF ==13595== at 0x4A092F2: strlen (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==13595== by 0x61BAF1: ui::text_layout::add_text(char const*, ui::text_layout::char_style const&) (text.cpp:115) ==13595== by 0x590388: mame_ui_manager::draw_text_full(render_container*, char const*, float, float, float, ui::text_layout::text_justify, ui::text_layout::word_wrapping, mame_ui_manager::draw_mode, rgb_t, rgb_t, float*, float*, float) (text.h:77) ==13595== by 0x5F9626: ui::menu::draw(unsigned int, float, float) (menu.cpp:725) ==13595== by 0x604439: ui::menu::process(unsigned int, float, float) (menu.cpp:401) ==13595== by 0x61004B: ui::menu_selector::handle() (selector.cpp:59) ==13595== by 0x60068A: ui::menu::ui_handler(render_container*, mame_ui_manager&) (menu.cpp:1236) ==13595== by 0x599922: std::_Function_handler<unsigned int (render_container*), void mame_ui_manager::set_handler<mame_ui_manager&>(ui_callback_type, unsigned int (*)(render_container*, mame_ui_manager&), unsigned int (render_container*, mame_ui_manager&))::{lambda(render_container*)#1}>::_M_invoke(std::_Any_data const&, render_container*&&) (ui.h:193) ==13595== by 0x591464: mame_ui_manager::update_and_render(render_container*) (functional:2271) ==13595== by 0x549EBE: emulator_info::draw_user_interface(running_machine&) (mame.cpp:330) ==13595== by 0x9638A7: video_manager::frame_update(bool) (video.cpp:225) ==13595== by 0x8F908B: running_machine::run(bool) (machine.cpp:346) ==13595== If you believe this happened as a result of a stack ==13595== overflow in your program's main thread (unlikely but ==13595== possible), you can try to increase the size of the ==13595== main thread stack using the --main-stacksize= flag. ==13595== The main thread stack size used in this run was 8388608. ==13595== ==13595== HEAP SUMMARY: ==13595== in use at exit: 74,513,845 bytes in 58,515 blocks ==13595== total heap usage: 356,591 allocs, 298,076 frees, 227,450,023 bytes allocated ==13595== ==13595== LEAK SUMMARY: ==13595== definitely lost: 20,987 bytes in 474 blocks ==13595== indirectly lost: 0 bytes in 0 blocks ==13595== possibly lost: 8,381,645 bytes in 37,416 blocks ==13595== still reachable: 66,111,213 bytes in 20,625 blocks ==13595== suppressed: 0 bytes in 0 blocks ==13595== Rerun with --leak-check=full to see details of leaked memory ==13595== ==13595== For counts of detected and suppressed errors, rerun with: -v ==13595== Use --track-origins=yes to see where uninitialised values come from ==13595== ERROR SUMMARY: 74 errors from 6 contexts (suppressed: 7 from 3) Killed |
|---|---|
|
No.12870
cuavas Administrator
Jul 1, 2016, 05:40
|
On further investigation, there's something wrong with how it's calculating the number of rows to draw and where the top line should be. It gets into the following state: this->item.size() = 54 visible_lines = 26 top_line = 37 show_top_arrow = true show_bottom_arrow = true So it's clearly confused - if the top line is 37, there's no way it can display 26 items. There simply aren't enough in the list of 54. So it runs off the end of the vector and reads garbage from uninitialised memory. |
|
No.12871
cuavas Administrator
Jul 1, 2016, 06:06
|
Fixed in mame0175-53-g0630edb |