06299: plugins/hiscore/init.lua: HiScore save path is based on current folder, Default should be a stable location like within the hiscore plugin folder.

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
06299	Interface	Feature	Always	Jul 16, 2016, 01:15	Jul 16, 2016, 13:20

Tester	ozfalcon	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	No change required	OS	Linux (32-bit)
Status [?]	Closed			Driver
Version	0.175	Fixed in Version		Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	06299: plugins/hiscore/init. lua: HiScore save path is based on current folder, Default should be a stable location like within the hiscore plugin folder.
Description	When the hiscore plugin is used, The Default location for the hi score saves is in the current folder. The Default location should be grouped together with the hiscore plugin for consistent behaviour. ATTACHED is a patch containing: 1. Change the Default location of "hi" folder to within the hiscore plugin path. 2. Slight improvement to the verbose output of the hiscore plugin. Patch was built using current git hiscore plugin. https://github.com/mamedev/mame/blob/master/plugins/hiscore/init.lua
Steps To Reproduce	Run Mame with the hiscore plugin enabled then play a game & make a hi score. The default "hi" score folder will be created wherever you started Mame (Current folder).
Additional Information	Minor improvement to the verbose output of hiscore script. sdlmame -v galaga \|grep hiscore: hiscore: Starting Galaga (Namco rev. B) hiscore: hiscoredata_path = hiscore.dat hiscore: found hiscore.dat entry for galaga hiscore: hiscore_path = hi/galaga.hi hiscore: scores read OK
Github Commit

Flags
Regression Version
Affected Sets / Systems	plugins/hiscore/init.lua

Attached Files	hiscorepath.diff (1,237 bytes) Jul 16, 2016, 01:15 Uploaded by ozfalcon Change Default location of hi folder & improve verbose output. [Show Content]

No.12944 Tafoid Administrator Jul 16, 2016, 10:18	This really isn't a bug to be reported, but a code submission/added feature. Please use GIT for a pull requests you want to send upstream and keep features and requests over there. Posting a patch here is likely to not get much attention. Visit: http://wiki.mamedev.org/index.php/Submitting_Source_Code to review submission rules and expectations.
No.12945 crazyc Developer Jul 16, 2016, 13:20	The problem with this is that we wanted to make it simple for most users to seamlessly keep using their existing hiscore files. Many would think that their old files are incompatible if they don't get loaded just because they need to be moved to a different directory. Also, if we do move the default directory, I'd prefer to put it in the nvram directory so they don't get deleted when users update their plugins.

No.12944

Tafoid

Administrator

Jul 16, 2016, 10:18

This really isn't a bug to be reported, but a code submission/added feature. Please use GIT for a pull requests you want to send upstream and keep features and requests over there.
Posting a patch here is likely to not get much attention. Visit: http://wiki.mamedev.org/index.php/Submitting_Source_Code to review submission rules and expectations.

No.12945

crazyc

Developer

Jul 16, 2016, 13:20

The problem with this is that we wanted to make it simple for most users to seamlessly keep using their existing hiscore files. Many would think that their old files are incompatible if they don't get loaded just because they need to be moved to a different directory. Also, if we do move the default directory, I'd prefer to put it in the nvram directory so they don't get deleted when users update their plugins.