06738: batrider: Perpendicular black lines all over the screen

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
06738	Graphics	Major	Always	Oct 29, 2017, 04:21	Oct 30, 2017, 11:59

Tester	wuemura	View Status	Public	Platform	MAME (Official Binary)
Assigned To		Resolution	No change required	OS	Windows 10 (64-bit)
Status [?]	Closed			Driver	toaplan/toaplan2.cpp
Version	0.191	Fixed in Version		Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	06738: batrider: Perpendicular black lines all over the screen
Description	Perpendicular black lines all over the screen
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	batrider

Attached Files	batrider.jpg (359,367 bytes) Oct 29, 2017, 04:21 Uploaded by wuemura
	mame.ini (10,642 bytes) Oct 29, 2017, 12:24 Uploaded by wuemura [Show Content]
	batrider2.jpg (85,103 bytes) Oct 29, 2017, 12:34 Uploaded by wuemura
	batrider.zip (506 bytes) Oct 29, 2017, 13:10 Uploaded by wuemura batrider "lay" file

No.14343 Osso Moderator Oct 29, 2017, 08:54	Can't reproduce. What -video are you using?
No.14348 wuemura Viewer Oct 29, 2017, 12:20	video is auto. For auto mame is using D3D.
No.14349 wuemura Viewer Oct 29, 2017, 12:37	The issue happens with official and git versions. Mame is complaining that there is no "320x240x4.png" file, as you can see on mame.ini the "effects" are off and if you delete mame.ini this still happens. If you go to video options the "Scanlines" are enabled, if you turn it off, the issue is gone, but it get back if you select scanlines again.
No.14351 wuemura Viewer Oct 29, 2017, 13:09	The cause of all this trouble is the attached file, extract it inside artwork.
No.14353 Tafoid Administrator Oct 29, 2017, 13:15	This is simply what you said, a problem with your lay file expecting a file in the artwork package but not having it available. I don't think what MAME is doing is wrong in that it is following exactly what the layout file is asking for.
No.14355 wuemura Viewer Oct 29, 2017, 13:25	I don't recall using this file, I don't know even how to create it. Maybe it was related with a previous bug that I was helping to test out, don't know. Either way, the file is valid, mame is loading it, the only problem is a png that it can't find. If there are no png, why mame is drawing a perpendicular black, semi-transparent (alpha?), overlay lines? And why is affecting screen shot? This should be like photoshop, a transparent layer of nothing.
No.14367 cuavas Administrator Oct 30, 2017, 10:29	Displaying a transparent layer doesn't really make sense - the element could be critical for the view to work. Using the contents of uninitialised memory as an alpha mask isn't desirable behaviour either. It should really report an error message and treat the view as unviable. I'm not going to make this a priority though: it doesn't crash or corrupt memory, and it doesn't happen if you don't have incomplete artwork.
No.14368 Tafoid Administrator Oct 30, 2017, 11:59 edited on: Oct 30, 2017, 12:00	MAME is doing as expected. It produces a dummy image and lets you know via console that an image could not be loaded. Closing. Noted in src\emu\rendlay.cpp: // if we can't load the bitmap, allocate a dummy one and report an error if (!m_bitmap.valid()) { // draw some stripes in the bitmap m_bitmap.allocate(100, 100); m_bitmap.fill(0); for (int step = 0; step < 100; step += 25) for (int line = 0; line < 100; line++) m_bitmap.pix32((step + line) % 100, line % 100) = rgb_t(0xff,0xff,0xff,0xff);