07046: dragngun, dragngunj: Screen goes black on 3rd stage and game stops

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07046	Gameplay	Critical (emulation)	Always	Jul 12, 2018, 14:23	Nov 22, 2018, 17:19

Tester	Robbbert	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	hap	Resolution	Fixed	OS	Windows Vista/7/8 (64-bit)
Status [?]	Resolved			Driver	dataeast/deco32.cpp
Version	0.199	Fixed in Version	0.204	Build	32-bit
		Fixed in Git Commit		Github Pull Request #

Summary	07046: dragngun, dragngunj: Screen goes black on 3rd stage and game stops
Description	Screen goes black on 3rd stage and game stops. Gets stuck in a loop @000628C
Steps To Reproduce	Play until you enter 3rd stage. Or, use dipswitch to enable Stage Select, start a game, press Alt to choose 3, press Ctrl, press it again when asked, black screen.
Additional Information	All other stages work via the Stage Select menu. Only stage 3 is a problem.
Github Commit

Flags
Regression Version	0.190
Affected Sets / Systems	dragngun, dragngunj

Attached Files

No.15270 Haze Senior Tester Jul 13, 2018, 00:49	is the 3rd level the one using raster effects, probably broke when the thing was converted to a shared device?
No.15271 Tafoid Administrator Jul 13, 2018, 01:40	Confirmed breaking version and taking daily builds from there isolated the likely breaking commit: https://github.com/mamedev/mame/commit/b91b3be70c22839ccd41381d6a7596de509b7c5e New device: Data East IRQ Controller Used by games in the cninja and deco32 drivers. This implies proper VBlank IRQ ack for all games now. Also added and improved raw screen parameters for various games.
No.15816 Osso Moderator Nov 21, 2018, 20:19	Fwiw, removing the '+1' from line 118 of deco_irq.cpp restores level 3 working. Might point at what's the problem.
No.15820 hap Developer Nov 22, 2018, 16:04	Yeah, I think it's fixed now. I've put interrupts at the start of hblank instead of at the start of the scanline.