07082: neogeo: Start button states are backward

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07082	DIP/Input	Minor	Always	Aug 31, 2018, 08:11	Sep 2, 2018, 08:54

Tester	Nightvoice	View Status	Public	Platform	MAME (Official Binary)
Assigned To		Resolution	Invalid report	OS	Windows Vista/7/8 (64-bit)
Status [?]	Closed			Driver	neogeo/neogeo.cpp
Version	0.201	Fixed in Version		Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	07082: neogeo: Start button states are backward
Description	Upon testing updated artwork for this system, I noticed that the states reported to artwork for the player 1 and 2 start buttons are reversed. The select game button displays correctly, but the other two don't (pressed vs. non-pressed).
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	neogeo

Attached Files

No.15368 Tafoid Administrator Aug 31, 2018, 18:57	Does that mean the artwork still needs work to be compatible? It doesn't sound like MAME itself is at fault.
No.15370 Nightvoice Tester Aug 31, 2018, 20:37 edited on: Aug 31, 2018, 20:39	It's not the artwork, it's the driver. When you have all three buttons referencing the same element, two read pressed and one reads not pressed, it is clearly a MAME problem. I took the advice and re-created the artwork file to use lamps instead of an LED for the game selected. That one was on me. This is a MAME issue, and I've done enough of these files to know that much.
No.15373 hap Developer Sep 1, 2018, 16:06	Where is this updated artwork?
No.15374 B2K24 Senior Tester Sep 1, 2018, 17:11	MAME Artwork X section of MW forums. "Neo Geo Multi-Game Update"
No.15375 hap Developer Sep 1, 2018, 18:49 edited on: Sep 2, 2018, 08:54	For neogeo(arcade), the select button is indeed at "SYSTEM" inputmask="0x0200". However, the other controls are at: "edge:joy:JOY1", 0x01 to 0x80 "edge:joy:JOY2", 0x01 to 0x80 "edge:joy:START", 0x01 and 0x04 https://github.com/mamedev/mame/blob/master/src/devices/bus/neogeo_ctrl/joystick.cpp#L127 edit in case it wasn't clear: the issue is your artwork, not MAME. Change the input tags/masks in the .lay file and it will work.