07449: apple3: Data corruption after write to floppy

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07449	Media Support	Major	Always	Oct 12, 2019, 22:01	Aug 5, 2022, 09:36

Tester	xolson	View Status	Public	Platform	MAME (Official Binary)
Assigned To	galibert	Resolution	Fixed	OS
Status [?]	Resolved			Driver	apple/apple3.cpp
Version	0.214	Fixed in Version	0.243	Build	64-bit
		Fixed in Git Commit	5b17570	Github Pull Request #

Summary	07449: apple3: Data corruption after write to floppy
Description	Apple /// Computer. Unreliable floppy disk writes.
Steps To Reproduce	Put system utilities disk in .D1 and business basic in .D2 I used the following command to start mame: mame64 apple3 -flop1 E:\a3test\Apple3SOS1.3SysUtils.dsk -flop2 E:\a3test\Apple3BusBasic1.1.dsk From system utilities menu, select System Configuration Program select Read a Driver File, hit right arrow key two times and type a 2 over the 1 in .D1/SOS.DRIVER to change it to .D2/SOS.DRIVER and press return Press ESC to go to the SCP men select Generate New System, hit enter and choose Yes to overwrite the old .D2/SOS.DRIVER At this point, the system usually pops up with a "Volume Not Found" error as the disk write has clobbered the directory of the business basic volume.
Additional Information	I tested older versions of mame and version 0.162 does not have this bug. 0.168, 0.177 do have the bug. Also there seems to be random font corruption on the system utilities screen about 50 percent of the time (maybe related to the special font download by the system utilities to draw the boxes around text)
Github Commit

Flags
Regression Version
Affected Sets / Systems	apple3

Attached Files

No.17076 xolson Tester Oct 13, 2019, 09:10 edited on: Oct 13, 2019, 09:11	I did additional testing and using mame 0.162 to copy the system utilities to a blank disk the resulting copy produces a system failure $01 during boot. mess 0.161 and 0.155 both copy the disk properly and it boots. So it seems the unreliable writing started at the combining of mess into mame.
No.20085 galibert Developer Apr 19, 2022, 16:04	Doesn't seem to repro anymore after 08f28cee11ce94e6656d4924c7a3c30614811783 or possibly 5b1757061251d14fc8cfd8817d17fcbf1d6dc3cc.
No.20086 R. Belmont Developer Apr 20, 2022, 00:56	This seems to be fixed with latest (specifically 5b1757061251d14fc8cfd8817d17fcbf1d6dc3cc). If you can pull latest from Github and try it, I'd appreciate it. If not, wait for 0.243 in about a week.
No.20429 xolson Tester Aug 5, 2022, 09:36	I can confirm that this issue is fixed. I tested it with mame-0.244-3.fc34.x86_64 mame-data-0.244-3.fc34.noarch rpm packages under Fedora 34 linux.