07469: vboy: sprite elements are cut off

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07469	Graphics	Major	Always	Oct 28, 2019, 02:04	Oct 28, 2019, 08:25

Tester	Kale	View Status	Public	Platform	MAME (Official Binary)
Assigned To	Robbbert	Resolution	Fixed	OS	Windows 10 (64-bit)
Status [?]	Resolved			Driver	atari/tvboy.cpp
Version	0.214	Fixed in Version	0.215	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	07469: vboy: sprite elements are cut off
Description	Sprite elements are cut off to the right in both screens. Examples: wariolnd cross hatch/automatic pause screen/title/gameplay waterwld title screen
Steps To Reproduce	Boot wariolnd, press start twice (up to the automatic pause screen)
Additional Information	Regression happened between 0.205 and 0.206 cycles
Github Commit

Flags
Regression Version	0.206
Affected Sets / Systems	vboy

Attached Files	0001.png (1,522 bytes) Oct 28, 2019, 02:05 Uploaded by Kale
	0002.png (6,230 bytes) Oct 28, 2019, 02:05 Uploaded by Kale wariolnd
	0004.png (6,271 bytes) Oct 28, 2019, 02:06 Uploaded by Kale waterwld

No.17138 Tafoid Administrator Oct 28, 2019, 03:13	Regression on December 28, 2018: https://github.com/mamedev/mame/commit/f1f0591f43f381123e8d9ec20c52eb7c0c332c79 Start cleaning up palette configuration: * Basically, initialisers go in the constructor arguments, and things for setting format go in set_format. * Initialisation patterns can be specified with an enum discriminator or with a FUNC and optionally a tag. * Formats can be specified with an enum discriminator or a size and function pointer. * You must always supply the number of entries when setting the format. * When initislising with a paletter initialisation member, you can specify the entries and indirecte entries together. * The palette_device now has a standard constructor, so use .set_entries if you are specifying entry count with no format/initialisation. * Also killed an overload on delegates that wasn't being useful.

No.17138

Tafoid

Administrator

Oct 28, 2019, 03:13

Regression on December 28, 2018: https://github.com/mamedev/mame/commit/f1f0591f43f381123e8d9ec20c52eb7c0c332c79

Start cleaning up palette configuration:

* Basically, initialisers go in the constructor arguments, and things for setting format go in set_format.
* Initialisation patterns can be specified with an enum discriminator or with a FUNC and optionally a tag.
* Formats can be specified with an enum discriminator or a size and function pointer.
* You must always supply the number of entries when setting the format.
* When initislising with a paletter initialisation member, you can specify the entries and indirecte entries together.
* The palette_device now has a standard constructor, so use .set_entries if you are specifying entry count with no format/initialisation.
* Also killed an overload on delegates that wasn't being useful.