07738: [Linux] [No X11] Build with NO_X11=1 is not fully taken into account in drawbgfx.cpp

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07738	Compiling	Major	Always	Aug 31, 2020, 21:19	Feb 24, 2023, 13:58

Tester	bbegin	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	Open	OS	Linux (32-bit)
Status [?]	Acknowledged			Driver
Version	N/A	Fixed in Version		Build	32-bit
		Fixed in Git Commit		Github Pull Request #

Summary	07738: [Linux] [No X11] Build with NO_X11=1 is not fully taken into account in drawbgfx.cpp
Description	When building with the option NO_X11=1, a component of BGFX is not fully processing the directive in the file ./src/osd/modules/render/drawbgfx.cpp At line #172, 195 and 196 there are hard references to X11. I personally workaround this by replacing: - Line #172 with: return nullptr; - Line #195-196 with: pd.ndt = NULL; pd.nwh = _window; It seems that a check for SDL2 Video Ouput is missing for the Raspberry Pi (or at least Linux) using KMS/DRM video output without X11 installed.
Steps To Reproduce	Compile with build option NO_X11=1 on Linux without X11 installed. Make command-line used: make -j 3 ARCHOPTS="-march=armv8-a+crc+simd -mcpu=cortex-a72 -mtune=cortex-a72 -mfpu=neon-fp-armv8 -mfloat-abi=hard -funsafe-math-optimizations -fprefetch-loop-arrays -fexpensive-optimizations" TARGETOS=linux NO_X11=1 NOWERROR=1 NO_USE_XINPUT=1 NO_USE_XINPUT_WII_LIGHTGUN_HACK=1 NO_OPENGL=1 USE_QTDEBUG=0 DEBUG=0 REGENIE=1 NO_BGFX=1 FORCE_DRC_C_BACKEND=1 NO_USE_PORTAUDIO=1
Additional Information
Github Commit

Flags	SDL specific, Verified with Code
Regression Version
Affected Sets / Systems

Attached Files

No.17930 Tafoid Administrator Sep 2, 2020, 02:31	Hopefully this will get the attention of someone who might be able to help.
No.21096 bbegin Tester Feb 24, 2023, 13:58	Issue resolved from 0.252.