Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
07880 Misc. Major Always Feb 22, 2021, 14:37 Mar 1, 2021, 16:32
Tester rcoltrane View Status Public Platform MAME (Official Binary)
Assigned To Resolution Open OS Windows 10 (64-bit)
Status [?] Acknowledged Driver grchamp.cpp
Version 0.228 Fixed in Version Build 64-bit
Fixed in Git Commit Github Pull Request #
Summary 07880: grchamp: Several regression since mame 0.103
Description Grand Champion had several regressions made after version 0.103, such as worse/missing sound and voice samples, worse graphics (black walls in tunnels and sprite priority bug in the headlights, missing fog effects, corrupted text layers, corrupted graphics at the podium).
Steps To Reproduce just play the game in both mame versions (0.103 and 0.228). the older driver is not perfect since other cars races outside of the track boundaries as well. but despite this, that version of the driver is way superior in almost every aspect.
Additional Information
Github Commit
Flags
Regression Version 0.103
Affected Sets / Systems grchamp
Attached Files
 
Relationships
There are no relationship linked to this issue.
Notes
5
User avatar
No.18484
Tafoid
Administrator
Feb 24, 2021, 22:10
I think by and large all this is known and why the machine is flagged as having incorrect graphics and sound.
I'd argue that this driver/machine be flagged as NOT_WORKING - likely has never worked to any sufficient capacity.
User avatar
No.18486
rcoltrane
Tester
Feb 25, 2021, 18:21
edited on: Feb 26, 2021, 12:16
I agree and I know that this driver was always far from perfect, but the 0.103 driver was much closer to the real thing than the latest one. At least in version 0.103 you can actually play the game, having most part of the funcionalities implemented, such as headlights during tunnel and fog sectors (the fog does not even show up now btw), voice samples at the beginning of each race and when you win a race, better rain and thunder implementation. All these things were better before, that's why I decided to open this report as a regression.
User avatar
No.18490
cuavas
Administrator
Feb 27, 2021, 10:42
If it’s better in 0.103 than it is now, then 0.103 is not the regression version. There are over a hundred versions between 0.103 and 0.229 – if you want to fill in the regression version, you need to actually identify the version where it gets worse.
User avatar
No.18492
rcoltrane
Tester
Feb 27, 2021, 17:29
I'm working on it. Will post the results here when its done.
User avatar
No.18503
rcoltrane
Tester
Mar 1, 2021, 16:32
edited on: Mar 1, 2021, 16:32
Ok, after some more tests, the major regression begun in mame version 0.109. According to the compiled history below, Aaron did some major rewrite/changes to the driver, which resulted in several regressions pointed by me in this report:

0.224: Added widescreen layouts with shifters [Firehawke].
0.222: READ/WRITE macros removal [Osso].
0.208: Removed MACHINE_CONFIG macros [Osso].
0.207: Removed QUANTUM_TIME MCFG macro [Osso].
0.204: Eliminated unnecessary address space argument from discrete sound handlers [AJR]. Removed AY8910 MCFG macros [Osso].
0.202: Allow watchdog timer to take any tag-like for the screen tag rather than only C strings [Vas Crabb]. Removed WATCHDOG MCFG macros [Osso].
0.198: Malcor and MASH added clones Grand Champion (set 2) and (set 3). Changed parent description to 'Grand Champion (set 1)'.
0.197: Use output finder for Grand Champion [Robbbert].
0.190: Fixed the sound latch system such that the bit 7 clearing actually works and properly synchronized the sound latch writes and bit 7 clears. Added memory map comment for sound cpu. Added missing sound NMI enable and hooked sound NMI to the sound semaphore. Added sound semaphore readback. Minor format changes to ease potential future code merge [Lord Nightmare].
0.163: Osso added save state support to Grand Champion.
0.155: Alex Jackson fixed character layer colors in Grand Champion. Swapped gfx1 roms ($0, 1000).
0.153: Use a real palette for Grand Champion [Alex Jackson].
0.140u1: Derrick Renaud optimized speed of DISCRETE_DAC_R1.
0.133u1: Brian Troha added DIP locations to Grand Champion.
0.129u6: Mr. Do added built-in layouts for Grand Champion.
0.125u7: Curt Coder fixed input port read at init time in Grand Champion.
0.118u3: Atari Ace added new AM_READ_PORT() macro which lets you define an input port read callback based on a port tag. This is now preferred over the previous technique of calling port_tag_to_handler() within an AM_READ() macro. Updated Grand Champion that uses the latter pattern to the new system.
0.113u2: Changed VSync to 60.606061 Hz.
0.109u3: Some additional Grand Champion cleanup [Aaron Giles].
0.108u5: Began rewrite of Grand Champion driver. Still work to do on collision detection, radar and some glitches [Aaron Giles]. Fixed Z80 CPU1/2 clock speeds to 3072000 Hz, VSync to 60.606060 Hz and gfx1-7 rom loading. Added 'Unused' dipswitch.
0.108u4: Aaron Giles did some cleanup and de-Achoization of the palette code. Removed some features used only by Grand Champion, which only complicated things for all the other drivers. Marked Grand Champion as imperfect graphics until it gets rewritten.
0.103: Hans Andersson fixed bug in the Grand Champion fog effect.
0.102u5: Significant improvements to the Grand Champion driver [Hans Andersson]: Tunnel headlights. Corrected rain effect. Corrected colors. Added speech. Improved collision detection (removed false collision when lightning). Improved fog effect. Added skeleton code for motor noise. Fixed graphic glitch in bottom row. Corrected CPU speed for Cpu board / Game board. Changed Z80 CPU1/2 clock speeds to 3MHz and palettesize to 4544 colors. Added Discrete sound.
0.87u1: Justin Szczap fixed one sound in Grand Champion.
0.37b12: Ernesto Corvi and Phil Stroffolino added 'Grand Champion' (Taito 1981). Known issues: PC3259 handling (for collision detection) is not accurate. Collision detection does work, but there are bits which define the type of collision (and determine whether a pit stop is required) that I don't know how to handle. Sound: Missing speech and engine noise. Rain rendering is probably wrong. "radar" is probably wrong. LED and tachometer display are missing/faked. Note that a dipswitch setting allows score to be displayed onscreen, but there's no equivalent for tachometer.
19th January 2001: Phil Stroffolino re-submitted the Grand Champion driver, working almost perfect.
6th June 2000: Phil Stroffolino sent yet another Grand Champion update with graphics fixes and preliminary collision detection working.
1st June 2000: Phil Stroffolino sent in an update for Grand Champion, fixing graphics and other stuff.
24th May 2000: Phil Stroffolino sent in a very preliminary work-in-progress driver for Grand Champion.
9th April 1999: Dumped Grand Champion.