07903: trs80l2, trs80m3: Multiple TRS-80 model 1 and 3 disks which previously worked no longer boot.

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07903	Media Support	Critical (emulation)	Always	Mar 15, 2021, 01:43	Apr 2, 2021, 22:46

Tester	star2root	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	Robbbert	Resolution	Fixed	OS
Status [?]	Resolved			Driver	trs/trs80m3.cpp
Version	0.229	Fixed in Version	0.231	Build
		Fixed in Git Commit	b0f2302	Github Pull Request #

Summary	07903: trs80l2, trs80m3: Multiple TRS-80 model 1 and 3 disks which previously worked no longer boot.
Description	These disk images worked in version 0.224 and now no longer work in 0.229. Model 1 M1-TRS27.DSK Model 3 M3-DOSPLUS.imd M3-TRSDOS13.imd ND80M3.dmk ND80M3.imd ld3-531.imd
Steps To Reproduce	Attempt to boot any of the listed disks.
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	trs80l2, trs80m3

Attached Files	M3-LDOS.zip (87,185 bytes) Mar 15, 2021, 01:43 Uploaded by star2root LDOS for Model 3, released by copyright owner
	Screen Shot 2021-03-15 at 1.43.28 PM.png (223,336 bytes) Mar 15, 2021, 17:44 Uploaded by star2root Power on with floppy mounted using version 0.224.
	Screen Shot 2021-03-15 at 1.42.41 PM.png (34,736 bytes) Mar 15, 2021, 17:45 Uploaded by star2root Power on with floppy mounted using version 0.229. Does not boot.
	Screen Shot 2021-03-15 at 5.24.23 PM.png (246,709 bytes) Mar 15, 2021, 21:26 Uploaded by star2root Make sure the floppy controller is enabled under "Machine Configuration".
	0000_210111.png (459 bytes) Mar 15, 2021, 22:53 Uploaded by Tafoid Initial Breakage - January 10,2021

No.18549 star2root Viewer Mar 15, 2021, 01:47 edited on: Mar 15, 2021, 16:36	https://www.tim-mann.org/misosys.html This link shows and describes software distribution rights for a great deal of Model I,III, and IV TRS 80 disk images.
No.18554 Tafoid Administrator Mar 15, 2021, 16:34	I'd like to know exactly how to "boot" the floppy. Simply attaching the image to -flop1 doesn't seem to do anything and there doesn't appear to be an obvious command to do so once at a prompt (DOS, BOOT, DIR). Please update Steps to Reproduce to explain how this is done as not everyone is versed in usage of this machine.
No.18555 star2root Viewer Mar 15, 2021, 17:41	You just attach the floppy and reset the system. That it doesn't do anything is the problem. By the way, which interface is preferred for bug reporting, here or GitHub?
No.18556 Osso Moderator Mar 15, 2021, 17:50	Bug reporting here, patches via Pull Request on Github.
No.18557 star2root Viewer Mar 15, 2021, 17:55	Changed severity back to critical because it meets the criteria described. Critical (emulation): Bug causes the game or program to crash or freeze (stop working) but MAME/MESS still runs. The "Diskette?" message is essentially a crash screen as the system can not load the OS.
No.18558 star2root Viewer Mar 15, 2021, 18:03	Who worked on this last since version 0.224? What was changed? I checked the machine and the driver file and found one change there which was initializing a variable to null. I reverted that and tested and it still didn't work so that wasn't the issue, the change that broke it must be somewhere else in the code.
No.18559 Tafoid Administrator Mar 15, 2021, 19:13	I've tried version 0.224, 0.220, 0.210, 0.200 and current Git and, for me, they all act the same - both in trs80m3 and trs80m4. Using: mame64_224 trs80m3 -norc -rompath d:\roms -flop1 C:\Users\THENGAMES\Desktop\trs80m3\ld3-531.imd -aviwrite ld3-531.avi I hit enter at Cass? and Memory Size? prompts and it shortly after pops up to a basic prompt. Here is an .avi video output of what I am getting (compressed due to extreme size for 5 seconds of emulation) https://mameload.mameworld.info/ld3-531.7z You mention self-compiled - is it possible it doesn't work with a release version and code local to you which may have made it work no longer does that?
No.18561 star2root Viewer Mar 15, 2021, 21:23	Oh! (Light bulb!!!) I forgot! You have to enable the floppy controller in the emulation settings! Sorry, I set mine like that so long ago that I forgot the default is to have the floppy disabled.
No.18562 Tafoid Administrator Mar 15, 2021, 22:10	Ok. Now I can duplicate and trace the issue breakage better. I'll report what I find. Not a fan of hiding floppy in a machine configuration like that as there are already slotted drives installed without it being active.
No.18563 star2root Viewer Mar 15, 2021, 22:20	Maybe if we can figure when this broke and I can fix it I'll see if I can at least change the default for the machine config for the floppy controller to on.
No.18564 Tafoid Administrator Mar 15, 2021, 22:52	Initial findings: https://github.com/mamedev/mame/commit/81e5960881ddeb9680c86ed3e4a4e685920a1d96 First breakage detected - January 10, 2021 Shows "Disk Error" on screen (added snap) Second point - January 16, 2021 Showing current "Diskette?" behavior. A few "floppy.cpp/.h" changes on that day
No.18565 star2root Viewer Mar 16, 2021, 00:18	It looks like floppy.cpp/.h have had some pretty wide reaching changes since 0.224. I think it's something in there. What is the link for the commit(s) you were looking at?
No.18567 star2root Viewer Mar 16, 2021, 05:29 edited on: Mar 16, 2021, 05:30	I managed to convert the disk image to mfi and mfm formats, but I get the same behavior with those formats as imd, the images boot using name version 0.224 but not name version 0.229, so it's not related to the disk image format. It's something that effects all floppy image formats for the trs80 models 1,3, and 4.
No.18571 Robbbert Senior Tester Mar 16, 2021, 13:36	Went through my collection and found a few floppies that boot on trs80l2 or trs80m3, but most of what was working no longer does. trs80m4 has been broken for ages so don't worry about that one.
No.18574 star2root Viewer Mar 16, 2021, 23:04 edited on: Mar 17, 2021, 00:00	Hey, Robbert, what floppy images do you have that actually BOOT?? Send me an email at barry.nelson@amobiledevice.com please! Any ideas what is wrong with it?
No.18617 Robbbert Senior Tester Mar 30, 2021, 13:41	I've made a change which allows the IMD disks you've listed to boot. I don't have M1-TRS27.DSK, ND80M3.dmk to test with.
No.18635 Robbbert Senior Tester Apr 2, 2021, 22:46	IMD's are fixed. User never came back with the other files, so may as well resolve it.