Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
08081 Sound Minor Always 13 days ago 13 days ago
Tester MARBIN View Status Public Platform MAME (Official Binary)
Assigned To kmg Resolution Fixed OS Windows 10 (64-bit)
Status [?] Resolved Driver srmp2.cpp
Version 0.235 Fixed in Version 0.236GIT Build 64-bit
Fixed in Git Commit 6d51055 Github Pull Request #
Summary 08081: srmp2, srmp3: No Character voices
Description Character voices are not played on srmp2 and srmp3. I confirmed this bug on mame 0.235.
Also, I confirmed that this bug does not exist on mame 0.226.
Steps To Reproduce
Additional Information
Github Commit
Flags
Regression Version 0.227
Affected Sets / Systems srmp2, srmp3
Attached Files
 
Relationships
There are no relationship linked to this issue.
Notes
3
User avatar
No.19239
Tafoid
Administrator
13 days ago
Tracking this suggests this is the commit to look at, traced to my daily binaries as October 31, 2020 - although I'm not sure why:
https://github.com/mamedev/mame/commit/aa4451f31ddcd0175ef0a56afee3b9126832659d
User avatar
No.19240
kmg
Tester
13 days ago
edited on: 13 days ago
There looks to be a type conversion error issue introduced by making m_adpcm_data uint8_t, though there may be other problems. At a glance it looks like the code is using -1 as a sentinel and this line is always false for instance: https://github.com/mamedev/mame/blob/668f3fd816e78dbab8affae8c645424288c55ee2/src/mame/drivers/srmp2.cpp#L233
User avatar
No.19241
Osso
Developer
13 days ago
Yes, my bad, sorry.