Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
08339 DIP/Input Minor Have not tried Jun 1, 2022, 05:22 Jun 11, 2022, 19:03
Tester sasuke View Status Public Platform MAME (Official Binary)
Assigned To Resolution Open OS Windows 10/11 (64-bit)
Status [?] Acknowledged Driver
Version 0.244 Fixed in Version Build 64-bit
Fixed in Git Commit Github Pull Request #
Summary 08339: salamand and clones: Credit is entered only one frame in test mode
Description #08315: salamand and clones: When press credit button sometimes gets 2 credits.
https://mametesters.org/view.php?id=8315

With the above fix, the credit entry in the game is now correct.
However, this fix will change the behavior of coin input in input test mode.
The behavior will be correct in-game, but I think the fix is not perfect.
At least in v0.105 and v0.157, it worked correctly both in-game and in test mode, so I think there is another correct fix.
Steps To Reproduce
Additional Information
Github Commit
Flags
Regression Version 0.244
Affected Sets / Systems salamand and clones
Attached Files
 
Relationships
related to 08315Resolvedkmg  salamand and clones: When press credit button sometimes gets 2 credits. 
Notes
4
User avatar
No.20273
hap
Developer
Jun 1, 2022, 07:58
It's a side effect of PORT_IMPULSE(x) (x = amount of frames input is active).
This happens with every driver that uses this, not just Salamander.
User avatar
No.20274
sasuke
Tester
Jun 1, 2022, 08:41
It no longer issue with gameplay, but I thought it might not perfect to use PORT_IMPULSE to fix this because it seems to be different from behavior of actual machine.
PS: See also Tafroid's post at #08315.
User avatar
No.20275
hap
Developer
Jun 1, 2022, 08:55
Even if you'd simulate the coin falling through the chute a more accurate way, like with an emu_timer, it would still be active very briefly in test mode.
User avatar
No.20289
sasuke
Tester
Jun 2, 2022, 09:42
edited on: Jun 2, 2022, 15:37
It not means about simulating physical behavior of coin.
Sorry for lack of clarity.
I think it is interrupt issue as this Tafroid's comment points to.
May be current is degraded implementation, as it worked fine in previous MAME.

https://mametesters.org/view.php?id=8315
Tafoid Wrote:
> Seems to a casualty of raw screen parameter changes:
> https://github.com/mamedev/mame/commit/e724f4d7e60c266138b1ab4ffd6cd2bb81858682
>
> There was another commit after which fixed coins for another game in the driver, perhaps it may or may not have the answer:
> https://github.com/mamedev/mame/commit/ad2e7a469463d02508c98a471332256e3e8621b2