08513: buckrog and clones: Sprite priorities are incorrect

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08513	Graphics	Major	Always	Nov 11, 2022, 19:39	Dec 19, 2022, 10:47

Tester	kmg	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	hap	Resolution	Fixed	OS	MacOS X
Status [?]	Resolved			Driver	sega/turbo.cpp
Version	0.249	Fixed in Version	0.251	Build	64-bit
		Fixed in Git Commit	2e531b9	Github Pull Request #

Summary	08513: buckrog and clones: Sprite priorities are incorrect
Description	Here's a link to VirtuaIceMan's thread who reported the bug: https://www.mameworld.info/ubbthreads/showthreaded.php?Cat=&Number=395133&page=0&view=expanded&sb=5&o=&fpart=1&vc=1 That gives most of the details so I won't bother repeating them here. I'll add that that the easiest way to see the bug is viewing the demo mode and watching for enemy ship shadows which will appear above the player sprite.
Steps To Reproduce
Additional Information	The bug may have been introduced in the last major video overhaul way back in 0.108u2: https://github.com/mamedev/historic-mame/commit/094f98a35a400bea3b2bf3f09d0246549a61c9e8#diff-c7e4daa27350034b59b65cc577458ec46e28e298fed7c6a28b8bb35d54809e79
Github Commit

Flags
Regression Version	0.108u2
Affected Sets / Systems	buckrog and clones

Attached Files

No.20893 kmg Senior Tester Dec 3, 2022, 06:05	When fighting the boss ship your ship is completely obscured to the point where you can't tell where you're shooting at all. I'd say this qualifies as "disturbs the gameplay in a significant manner", whence severity bumped up to "Major".
No.20966 hap Developer Dec 18, 2022, 20:23	Try here (I only checked attract mode and played for a short while) https://github.com/mamedev/mame/commit/2e531b9f256599419dbb512c14fbba7705c89397
No.20967 kmg Senior Tester Dec 19, 2022, 08:03	I played the parent and all clones. Every priority issue mentioned in the mameworld thread and any others that I had noticed (shadows, explosions, etc) look good to me now. Nice work!
No.20968 hap Developer Dec 19, 2022, 10:47	Great