08554: cdimono1: Possible incorrect scaling in screenshots

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08554	Interface	Minor	Always	Jan 29, 2023, 23:23	Jan 30, 2023, 11:29

Tester	Foxhack	View Status	Public	Platform	MAME (Official Binary)
Assigned To		Resolution	Invalid report	OS	Windows 10/11 (64-bit)
Status [?]	Closed			Driver	philips/cdi.cpp
Version	0.251	Fixed in Version		Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	08554: cdimono1: Possible incorrect scaling in screenshots
Description	A friend noticed some weirdness while reporting another bug (which ended up being a minor misconfiguration) at Github. When I tried to help her we noticed an issue with the screenshots, so I'm making this to see if this is a bug or not. Taking a screenshot of any CDI game (or even the bios) with the LCD screen on top results in a screenshot that has a 768x310 resolution. That's the width of the screen, plus the two combined screens (Screen 0 is the game screen, while Screen 1 is the LCD.) But if you use the menu to take screenshots of each item separately... Screen 0 is 280 pixels tall, and Screen 1 is 22 pixels tall. The combined image is stretching Screen 0 so it's 288 pixels tall, instead of combining both images into a screenshot that's 302 pixels tall. I used all the available screenshot aspect ratios and all the separate screenshots have the right height, but the combined one is giving me the wrong combined height. The screenshot I've attached shows what's going on. The part on the left is MAME's combined screenshot output, while the right side is the individual screenshots stacked together. (The LCD part at the top is stretched horizontally to fit the full screen display, so it showing up that small in a screenshot is in fact correct.) So is it supposed to be stretching the screen 0 display like it does in the screenshot? I quote cuavas from that bug report, "Multiple screens in a view won’t produce a "perfect” screenshot if they don’t all have the same pixel density and aspect ratio. It’s unavoidable." But considering Screen 1 / the LCD is centered and stretched horizontally to fit Screen 0 / the display, why is the bottom screen being scaled to add those extra 8 pixels?
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	cdimono1

Attached Files	cdimono1-screen comparisons.png (29,276 bytes) Jan 29, 2023, 23:23 Uploaded by Foxhack

No.21055 cuavas Administrator Jan 30, 2023, 11:29	You don't own issues to ask questions. There are forums for that.