08664: buckrog and clones, subroc3d: Coin counters increase at each boot up even though credits are not being added

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08664	Misc.	Minor	Always	Jun 16, 2023, 05:26	Jun 16, 2023, 18:30

Tester	Balthier	View Status	Public	Platform	MAME (Official Binary)
Assigned To	hap	Resolution	Fixed	OS	Windows 10/11 (64-bit)
Status [?]	Resolved			Driver	sega/turbo.cpp
Version	0.255	Fixed in Version	0.256	Build	64-bit
		Fixed in Git Commit	3e94326	Github Pull Request #

Summary	08664: buckrog and clones, subroc3d: Coin counters increase at each boot up even though credits are not being added
Description	When running a game, the coin counters numbers in the machine's cfg file will increase by 1 on each start up even though credits are not being added by the user.
Steps To Reproduce	1. run any of the affected games (subroc3d or zoom909). 2. let the game run for a little bit, just don't add any credits. 3. exit the game, go to your cfg directory and examine the game's cfg file. The coin counter numbers should be at 1 now. 4. run the same game and repeat step 2. 5. repeat step 3, and the counters will now be at 2.
Additional Information	Here's the subroc3d.cfg as an example: <?xml version="1.0"?> <!-- This file is autogenerated; comments and unknown tags will be stripped --> <mameconfig version="10"> <system name="subroc3d"> <counters> <coins index="0" number="1" /> <coins index="1" number="1" /> </counters> </system> </mameconfig> The turbo sets are all okay. Mame 0.147 is the version this started happening with. The affected games also only count inserted credits onto the first counter (coins index="0") when pressing the 6 key. Correct me if I am making the wrong assumption here, but if a coin is inserted via pressing 6 then shouldn't the second coin counter (coins index="1") be the only one to increase in value? The turbo sets only show 1 coin counter but it should be 2? ( http://adb.arcadeitalia.net/dettaglio_mame.php?game_name=turbo ) I only see coins index="0" if I press 5 or 6.
Github Commit

Flags
Regression Version
Affected Sets / Systems	buckrog and clones, subroc3d

Attached Files

No.21545 hap Developer Jun 16, 2023, 09:39	The autoincrementing coincounter is fixed here: https://github.com/mamedev/mame/commit/3e94326fe23d2b62a27a69a720d6f36bbf620496
No.21548 Balthier Tester Jun 16, 2023, 15:21	Does that commit fix the counters on all machines that use them in Mame? I ask because I may have more similar reports to file here for other drivers, and I don't want to spam the site with them needlessly.
No.21550 hap Developer Jun 16, 2023, 15:51	Only for sega/turbo.cpp I didn't set this report to resolved because you mentioned that the coincounter number could be wrong too.
No.21551 Balthier Tester Jun 16, 2023, 16:14	Ok. May I ask, how do I verify if the amount of coin indexes is correct for any given machine? Example, I notice that when comparing the "Coins" stat listed at http://adb.arcadeitalia.net ( https://i.imgur.com/QSpvyEs.png ) for the 6 player X-Men machine to what it has for counters, the site shows 6 of course but the cfg file only shows 1 counter. Normal or not normal? For now I am focusing on what is auto-incrementing or creating strange values, but if I notice wrong amount of counters I kind of want to take note of that as well if it is somehow related to the incrementing.
No.21552 hap Developer Jun 16, 2023, 17:12	I wouldn't trust a database site like that for verifications, because, a lot of the scraped info is from MAME itself. It mentions the coin slots, not coincounters, right? In the case of these Sega games, manuals with schematics are available but I didn't check them for this.
No.21553 hap Developer Jun 16, 2023, 17:25	Ok, it does have 2 coincounters. And I guess it's by design that it only triggers the 2nd coincounter when the Coin A/Coin B dipswitch settings are not equal.
No.21554 Balthier Tester Jun 16, 2023, 17:42	I don't necessarily "trust" arcadeitalia but like you said the data there is basically the Mame info though. And you're saying that the dip switch coin settings affect the coin indexes showing up in the cfg files if I am understanding that correctly. If that's the case then I don't understand the case of the 6 player X-Men machine having 1 counter, that game uses settings stored in the nvram and has no dips. Well, unless someone super knowledgeable about this can give a real good explanation on these mechanisms I am going to just leave this particular topic alone for now before getting too far from the original issue.
No.21555 hap Developer Jun 16, 2023, 18:30	My comment about dipswitches changing coincounter behaviour is specific to turbo/subroc3d/buckrog, not xmen. To clarify, these coin counters in MAME, they are triggered by the emulated software/hardware. It's not a counter from MAME itself. So, if the emulated hardware did not have coincounters, MAME won't keep track of them.