00173: victory: when you use the shield, the speech and sound gets garbled/corrupted.

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
00173	Sound	Minor	Always	Jan 25, 2008, 06:11	Apr 29, 2010, 00:44

Tester	The tECHIDNA	View Status	Public	Platform
Assigned To	Lord Nightmare	Resolution	Fixed	OS
Status [?]	Resolved			Driver	exidy/victory.cpp
Version	0.37b4	Fixed in Version	0.137u3	Build
		Fixed in Git Commit		Github Pull Request #

Summary	00173: victory: when you use the shield, the speech and sound gets garbled/corrupted.
Description	About 60% of the time, when you use the shield, the speech and sound gets garbled/corrupted, then all sound is cut off until you die.
Steps To Reproduce
Additional Information	Probable cause: "Fixed sound in the Exidy games. [Aaron Giles]"
Github Commit

Flags
Regression Version	0.37b4
Affected Sets / Systems	victory

Attached Files

No.06020 Lord Nightmare Developer Apr 28, 2010, 18:37 edited on: Apr 28, 2010, 18:38	Fixed by TMS5220 FIFO rewrite, possibly slightly earlier
No.06021 M.A.S.H. Senior Tester Apr 28, 2010, 18:59	The fixed version is 0.137u3. The sound with shield only works in u3.
No.06022 Lord Nightmare Developer Apr 29, 2010, 00:44 edited on: Apr 29, 2010, 00:47	fixed. The actual cause of this bug is rather interesting: the "Shields up!" tms5220 sample is missing the stop frame at the end of it, so the tms5220 runs out of data when playing the last frame and halts speech. victory then sends a new command 0x60 (speak external) and the "three" sample afterward, expecting it to be spoken immediately. The problem was that the talk status would not be unset by the time the "three" sample was sent, causing the tms5220 to get way confused (due to a separate bug) about what was speech data and what was commands, and get its data offset weirdly, which would in turn confuse the audio 6502 which would hang, halting all audio with a burst of garbled speech.