01731: atarifb, atarifb1, atarifb4, abaseb, abaseb2: LED errors in driver

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
01731	Graphics	Minor	Always	Apr 19, 2008, 22:47	Jun 16, 2020, 19:09

Tester	Mr. Do	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	hap	Resolution	Fixed	OS	Windows XP/Vista 64-bit
Status [?]	Resolved			Driver	atari/atarifb.cpp
Version	0.124u3	Fixed in Version	0.222	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	01731: atarifb, atarifb1, atarifb4, abaseb, abaseb2: LED errors in driver
Description	In atarifb and abaseb, there are five LEDs total for each player; the four LEDs to select the play, and the fifth LED is the play/select button. This LED should flash when for both players when "Select Play" flashes on screen. In atarifb4, there are six LEDs total for each set of players (1+2 and 3+4); five for play select, and a sixth for the "Select Play." In the machine driver, there are LEDs defined as "ledleft(0-4)" and "ledright(0-4)." LEDs 0-3 work correctly in each driver. LED 4 in atarifb and abaseb does nothing. LED 4 in atarifb stays lit at all times. So today, the play/select LED is not defined for any games, and the fifth playlist LED does not work correctly in atarifb4.. Also, the LEDs seem to be labeled backwards. Player One controls the left side of the screen, but "ledright" lights up for Player One. Vice versa for Player Two.
Steps To Reproduce	You can use the attached artwork file to test atarifb. LEDs 0-3 are assigned to the playlist; LED 4 is assigned to the play/select button at this point. You can rename the file to abaseb and atarifb4 to test the other two games.
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	atarifb, atarifb1, atarifb4, abaseb, abaseb2

Attached Files	atarifb.zip (1,120,547 bytes) Apr 19, 2008, 22:47

No.00739 Tafoid Administrator Apr 20, 2008, 00:33 edited on: Apr 20, 2008, 00:35	Set to acknowledged for Developer input. According to the picture of the control panels, there is indeed 5 different plays for the 4 player version - 4 selectable plays in the two player sets.