01990: "Restore previous value" flag doesn't work

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
01990	Cheat System	Major	Always	Jul 8, 2008, 14:40	Jul 17, 2008, 23:59

Tester	stephh	View Status	Public	Platform	MAME (Official Binary)
Assigned To		Resolution	Won't fix	OS	Windows XP/Vista 32-bit
Status [?]	Closed			Driver
Version	0.126	Fixed in Version		Build	I686
		Fixed in Git Commit		Github Pull Request #

Summary	01990: "Restore previous value" flag doesn't work
Description	Turning OFF a cheat with this flag doesn't put the previous value back while it was OK before the cheat engine "rewrite".
Steps To Reproduce	Here is an easy example based on 'perfrman' with this cheat line from Pugsy's latest official cheat database : :perfrman:20800000:1843:00000018:FFFFFFFF:Invincibility 1) Turn this cheat ON then reset the game (F3 key). The game hangs on a "ROM CHECK 1" screen (see attached snapshot). This is the correct behaviour as this cheat affects ROM area and the game has a ROM check at the beginning of the game. 2) Turn this cheat OFF (either by toggling the cheat in the "Enable/Disable a Cheat" menu or by pressing the F6 key to disable all the active cheats) then reset the game again (F3 key).The game STILL hangs on the SAME "ROM CHECK 1" screen. I hope that someone will fix this as soon as possible because we REALLY need such kind of cheats !
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems

Attached Files	perfrman.png (1,090 bytes) Jul 8, 2008, 14:40

No.01540 ShimaPong Tester Jul 8, 2008, 15:31	Try to the following code :perfrman::8100000080::1843::00000018::FFFFFFFF:Invincibility
No.01544 Iaspis Tester Jul 8, 2008, 16:39	Should this be registered as a mame bug? I mean it's apparently cheatfile's fault.. we just need a new one.
No.01545 Tafoid Administrator Jul 8, 2008, 17:03	If a selected cheat worked in the prior cheat.c implementation and doesn't now - I would say a bug report is warranted to identify and fix the compatibility between old and new formats. If it's a bug that didn't work in the old cheat.c implementation - it has no business being addressed here. Also, any bugs that show up in games with simply having -CHEAT activated (with or without .DAT file) is also valid. A new category "CHEAT SYSTEM" as recently created to make sure all the related bugs would be easier to report and find.
No.01677 Fujix Administrator Jul 17, 2008, 23:59	Redesign of the cheat system is in progress. Bugs for the old system are invalid now.